content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java - Issue 2455653002: Make clear that WindowAndroid::getDisplay must be used when supporting multi-display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java

Issue 2455653002: Make clear that WindowAndroid::getDisplay must be used when supporting multi-display. (Closed)

Patch Set: Revert change that snuck in from other branch Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java ('k') | ui/android/java/src/org/chromium/ui/base/WindowAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java

index ba4fd9e88b750d940fbf0b75661bb1a276e3bf9f..80a80cdc7f972e1b7121681b04313b1d226b3271 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java

@@ -52,7 +52,7 @@ public class ScreenOrientationProvider {

// If the tab is being reparented, we don't have a display strongly associated with

// it, so we get the default display.

DisplayAndroid displayAndroid = (window != null) ? window.getDisplay()

- : DisplayAndroid.get(context);

+ : DisplayAndroid.getNonMultiDisplay(context);

int rotation = displayAndroid.getRotation();

if (rotation == Surface.ROTATION_0 || rotation == Surface.ROTATION_180) {

if (displayAndroid.getDisplayHeight() >= displayAndroid.getDisplayWidth()) {