android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java - Issue 2455653002: Make clear that WindowAndroid::getDisplay must be used when supporting multi-display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java

Issue 2455653002: Make clear that WindowAndroid::getDisplay must be used when supporting multi-display. (Closed)

Patch Set: Revert change that snuck in from other branch Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java

index 6f9e11a99f816090b5326feec7c080a75f958d83..7147e03d4560be16cc26427cac54f4fa28d99568 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java

@@ -181,7 +181,7 @@ public class AwContentsAnchorViewTest extends AwTestBase {

}

private LayoutParams setLayoutParams(View anchorView, int coords, int dimension) {

- float scale = (float) DisplayAndroid.get(mContainerView.getContext()).getDIPScale();

+ float scale = DisplayAndroid.getNonMultiDisplay(mContainerView.getContext()).getDIPScale();

mViewDelegate.setViewPosition(

anchorView, coords, coords, dimension, dimension, scale, 10, 10);

return anchorView.getLayoutParams();

@@ -191,7 +191,7 @@ public class AwContentsAnchorViewTest extends AwTestBase {

FrameLayout containerView = new FrameLayout(getActivity());

getActivity().addView(containerView);

mViewDelegate.updateCurrentContainerView(containerView,

- DisplayAndroid.get(mContainerView.getContext()));

+ DisplayAndroid.getNonMultiDisplay(mContainerView.getContext()));

return containerView;

}