Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java

Issue 2455653002: Make clear that WindowAndroid::getDisplay must be used when supporting multi-display. (Closed)
Patch Set: Revert change that snuck in from other branch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
index e5619e12b3f01f8d13d057e65b2974859867a9c0..9e83171e7a940163d6f477990268c43c025dee39 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
@@ -322,7 +322,7 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
enableJavaScriptOnUiThread(testContainerView.getAwContents());
final double deviceDIPScale =
- DisplayAndroid.get(testContainerView.getContext()).getDIPScale();
+ DisplayAndroid.getNonMultiDisplay(testContainerView.getContext()).getDIPScale();
final int targetScrollXCss = 233;
final int targetScrollYCss = 322;
final int targetScrollXPix = (int) Math.ceil(targetScrollXCss * deviceDIPScale);
@@ -356,7 +356,7 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
enableJavaScriptOnUiThread(testContainerView.getAwContents());
final double deviceDIPScale =
- DisplayAndroid.get(testContainerView.getContext()).getDIPScale();
+ DisplayAndroid.getNonMultiDisplay(testContainerView.getContext()).getDIPScale();
final int targetScrollXCss = 132;
final int targetScrollYCss = 243;
final int targetScrollXPix = (int) Math.floor(targetScrollXCss * deviceDIPScale);
@@ -384,7 +384,7 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
enableJavaScriptOnUiThread(testContainerView.getAwContents());
final double deviceDIPScale =
- DisplayAndroid.get(testContainerView.getContext()).getDIPScale();
+ DisplayAndroid.getNonMultiDisplay(testContainerView.getContext()).getDIPScale();
final int targetScrollXCss = 132;
final int targetScrollYCss = 243;
final int targetScrollXPix = (int) Math.floor(targetScrollXCss * deviceDIPScale);
@@ -414,7 +414,7 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
enableJavaScriptOnUiThread(testContainerView.getAwContents());
final double deviceDIPScale =
- DisplayAndroid.get(testContainerView.getContext()).getDIPScale();
+ DisplayAndroid.getNonMultiDisplay(testContainerView.getContext()).getDIPScale();
final int targetScrollXCss = 132;
final int targetScrollYCss = 243;
final int targetScrollXPix = (int) Math.floor(targetScrollXCss * deviceDIPScale);
@@ -458,7 +458,7 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
final int targetScrollYPix = dragStepSize * dragSteps;
final double deviceDIPScale =
- DisplayAndroid.get(testContainerView.getContext()).getDIPScale();
+ DisplayAndroid.getNonMultiDisplay(testContainerView.getContext()).getDIPScale();
final int maxScrollXPix = 101;
final int maxScrollYPix = 211;
// Make sure we can't hit these values simply as a result of scrolling.
@@ -683,7 +683,7 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
enableJavaScriptOnUiThread(testContainerView.getAwContents());
final double deviceDIPScale =
- DisplayAndroid.get(testContainerView.getContext()).getDIPScale();
+ DisplayAndroid.getNonMultiDisplay(testContainerView.getContext()).getDIPScale();
final int targetScrollYCss = 243;
final int targetScrollYPix = (int) Math.ceil(targetScrollYCss * deviceDIPScale);
@@ -789,8 +789,8 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
// Containers to execute asserts on the test thread
final AtomicBoolean canZoomIn = new AtomicBoolean(false);
- final AtomicReference<Float> atomicOldScale = new AtomicReference<Float>();
- final AtomicReference<Float> atomicNewScale = new AtomicReference<Float>();
+ final AtomicReference<Float> atomicOldScale = new AtomicReference<>();
+ final AtomicReference<Float> atomicNewScale = new AtomicReference<>();
final AtomicInteger atomicOldScrollRange = new AtomicInteger();
final AtomicInteger atomicNewScrollRange = new AtomicInteger();
final AtomicInteger atomicContentHeight = new AtomicInteger();
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698