Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
245563002:
Fixes flaky HttpServer.SendRaw failures. (Closed)
|
Created:
6 years, 8 months ago by gunsch Modified:
6 years, 7 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, Ken Rockot(use gerrit already) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFixes flaky HttpServer.SendRaw failures.
While not observed on Linux, running on OSX appears to be much
flakier. Calls to StreamListenSocket::Send are non-blocking writes,
so a single read for multiple writes sometimes did not execute as
expected.
R=rsleevi@chromium.org
BUG=365067
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266647
Patch Set 1 #Patch Set 2 : whitespace #
Total comments: 4
Patch Set 3 : review fixes #Messages
Total messages: 26 (0 generated)
https://codereview.chromium.org/245563002/diff/20001/net/server/http_server_u... File net/server/http_server_unittest.cc (right): https://codereview.chromium.org/245563002/diff/20001/net/server/http_server_u... net/server/http_server_unittest.cc:98: int total_bytes_received = 0; do you need to clear a |message| here? https://codereview.chromium.org/245563002/diff/20001/net/server/http_server_u... net/server/http_server_unittest.cc:330: ASSERT_TRUE(client.Read(&response, 37)); How was this magical number calculated?
https://codereview.chromium.org/245563002/diff/20001/net/server/http_server_u... File net/server/http_server_unittest.cc (right): https://codereview.chromium.org/245563002/diff/20001/net/server/http_server_u... net/server/http_server_unittest.cc:98: int total_bytes_received = 0; On 2014/04/23 21:46:03, mef wrote: > do you need to clear a |message| here? Done. https://codereview.chromium.org/245563002/diff/20001/net/server/http_server_u... net/server/http_server_unittest.cc:330: ASSERT_TRUE(client.Read(&response, 37)); On 2014/04/23 21:46:03, mef wrote: > How was this magical number calculated? Done.
lgtm
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/245563002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by gunsch@chromium.org
The CQ bit was unchecked by gunsch@chromium.org
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/245563002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/245563002/40001
The CQ bit was unchecked by commit-bot@chromium.org
The commit queue went berserk retrying too often for a seemingly flaky test on builder android_dbg: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db... http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/245563002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on android_dbg_triggered_tests
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/245563002/40001
Message was sent while issue was closed.
Change committed as 266647 |
