Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2455623003:
Make sectionRowIndex be more conforming to spec (Closed)
DescriptionMake sectionRowIndex be more conforming to spec
Make sectionRowIndex be more conforming to spec by
reusing the rows getters from HTMLTableSectionElement
and HTMLTableElement, which is also potentially more
efficient since they use caching.
BUG=654777
Committed: https://crrev.com/c9a5c42229e57de44db61c45ee9cf71210f3c205
Cr-Commit-Position: refs/heads/master@{#428013}
Patch Set 1 #Patch Set 2 : A bit cleaner #
Total comments: 2
Patch Set 3 : Patch for landing #Messages
Total messages: 16 (10 generated)
Description was changed from ========== 654777 WIP BUG= ========== to ========== Make sectionRowIndex be more conforming to spec BUG=654777 ==========
Description was changed from ========== Make sectionRowIndex be more conforming to spec BUG=654777 ========== to ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is potentially more efficient since they get cached. BUG=654777 ==========
Description was changed from ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is potentially more efficient since they get cached. BUG=654777 ========== to ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is potentially more efficient since they use caching. BUG=654777 ==========
Description was changed from ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is potentially more efficient since they use caching. BUG=654777 ========== to ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is also potentially more efficient since they use caching. BUG=654777 ==========
rob.buis@samsung.com changed reviewers: + foolip@chromium.org
PTAL.
foolip@chromium.org changed reviewers: + tkent@chromium.org
I'll be sheriff Thu and OOO Fri, suggest tkent@ as a reviewer instead.
lgtm https://codereview.chromium.org/2455623003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp (right): https://codereview.chromium.org/2455623003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp:58: static int findIndexInRowCollection(HTMLCollection* rows, nit: Because |rows| isn't nullptr and it isn't modified, the argument type should be |const HTMLCollection&|. https://codereview.chromium.org/2455623003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp:59: const HTMLTableRowElement* target) { nit: |target| isn't nullptr. The argument type should be |const HTMLTableRowElement&|.
The CQ bit was checked by rob.buis@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2455623003/#ps40001 (title: "Patch for landing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is also potentially more efficient since they use caching. BUG=654777 ========== to ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is also potentially more efficient since they use caching. BUG=654777 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is also potentially more efficient since they use caching. BUG=654777 ========== to ========== Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is also potentially more efficient since they use caching. BUG=654777 Committed: https://crrev.com/c9a5c42229e57de44db61c45ee9cf71210f3c205 Cr-Commit-Position: refs/heads/master@{#428013} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c9a5c42229e57de44db61c45ee9cf71210f3c205 Cr-Commit-Position: refs/heads/master@{#428013} |
