Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2455623003: Make sectionRowIndex be more conforming to spec (Closed)

Created:
4 years, 1 month ago by rwlbuis
Modified:
4 years, 1 month ago
Reviewers:
tkent, foolip
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sectionRowIndex be more conforming to spec Make sectionRowIndex be more conforming to spec by reusing the rows getters from HTMLTableSectionElement and HTMLTableElement, which is also potentially more efficient since they use caching. BUG=654777 Committed: https://crrev.com/c9a5c42229e57de44db61c45ee9cf71210f3c205 Cr-Commit-Position: refs/heads/master@{#428013}

Patch Set 1 #

Patch Set 2 : A bit cleaner #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp View 1 2 2 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
rwlbuis
PTAL.
4 years, 1 month ago (2016-10-26 19:45:57 UTC) #6
foolip
I'll be sheriff Thu and OOO Fri, suggest tkent@ as a reviewer instead.
4 years, 1 month ago (2016-10-26 22:40:12 UTC) #8
tkent
lgtm https://codereview.chromium.org/2455623003/diff/20001/third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp File third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp (right): https://codereview.chromium.org/2455623003/diff/20001/third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp#newcode58 third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp:58: static int findIndexInRowCollection(HTMLCollection* rows, nit: Because |rows| isn't ...
4 years, 1 month ago (2016-10-27 02:31:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455623003/40001
4 years, 1 month ago (2016-10-27 12:36:51 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-27 13:43:02 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 13:44:53 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9a5c42229e57de44db61c45ee9cf71210f3c205
Cr-Commit-Position: refs/heads/master@{#428013}

Powered by Google App Engine
This is Rietveld 408576698