Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2455613002: Fix index used to join results of DOM.getDocument and CSS.getLayoutTreeAndStyles (Closed)
Patch Set: Fix skew between property names and values when emepty ones are skipped. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index 1f472c210cc94a39b8e81a539a435668f6ef0ae0..91d1c6f7f9b2c3fcd69a7d1018f2f7a6be681adf 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -2911,7 +2911,7 @@
"id": "LayoutTreeNode",
"type": "object",
"properties": [
- { "name": "backendNodeId", "$ref": "DOM.BackendNodeId", "description": "The BackendNodeId of the related DOM node." },
+ { "name": "nodeId", "$ref": "DOM.NodeId", "description": "The id of the related DOM node matching one from DOM.GetDocument." },
{ "name": "boundingBox", "$ref": "DOM.Rect", "description": "The absolute position bounding box." },
{ "name": "layoutText", "type": "string", "optional": true, "description": "Contents of the LayoutText if any" },
{ "name": "inlineTextNodes", "type": "array", "optional": true, "items": { "$ref": "InlineTextBox" }, "description": "The post layout inline text nodes, if any." },
@@ -3132,7 +3132,7 @@
{ "name": "layoutTreeNodes", "type": "array", "items": { "$ref": "LayoutTreeNode" } },
{ "name": "computedStyles", "type": "array", "items": { "$ref": "ComputedStyle" } }
],
- "description": "For the main document and any content documents, return the LayoutTreeNodes and a whitelisted subset of the computed style.",
+ "description": "For the main document and any content documents, return the LayoutTreeNodes and a whitelisted subset of the computed style. It only returns pushed nodes, on way to pull all nodes is to call DOM.getDocument with a depth of -1.",
"experimental": true
}
],
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698