third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h - Issue 2455613002: Fix index used to join results of DOM.getDocument and CSS.getLayoutTreeAndStyles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

Issue 2455613002: Fix index used to join results of DOM.getDocument and CSS.getLayoutTreeAndStyles (Closed)

Patch Set: Fix skew between property names and values when emepty ones are skipped. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

index caf1477186dd15ce7883a29d289ffa05fbdef359..6cff66eda3a0a8444fa0f5c4ee58bd061552a406 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

@@ -332,6 +332,8 @@ class CORE_EXPORT InspectorCSSAgent final

ComputedStylesMap& styleToIndexMap,

protocol::Array<protocol::CSS::ComputedStyle>& computedStyles);

+ // A non-zero index corresponds to a style in |computedStyles|, -1 means an

+ // empty style.

int getStyleIndexForNode(

Node*,

const Vector<std::pair<String, CSSPropertyID>>& cssPropertyWhitelist,