Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: headless/public/util/dom_tree_extractor.cc

Issue 2455613002: Fix index used to join results of DOM.getDocument and CSS.getLayoutTreeAndStyles (Closed)
Patch Set: Fix skew between property names and values when emepty ones are skipped. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/public/util/dom_tree_extractor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/dom_tree_extractor.cc
diff --git a/headless/public/util/dom_tree_extractor.cc b/headless/public/util/dom_tree_extractor.cc
index 70ed8afe046a2bf87153f00bfb89bd11207ecd80..8b43162cc9a89f008cc773627e3d1b98d0069376 100644
--- a/headless/public/util/dom_tree_extractor.cc
+++ b/headless/public/util/dom_tree_extractor.cc
@@ -85,14 +85,11 @@ void DomTreeExtractor::ExtractLayoutTreeNodes() {
dom_tree_.layout_tree_nodes_.reserve(
dom_tree_.layout_tree_and_styles_result_->GetLayoutTreeNodes()->size());
- // Only extract layout tree nodes that map to a DOM node.
for (const std::unique_ptr<css::LayoutTreeNode>& layout_node :
*dom_tree_.layout_tree_and_styles_result_->GetLayoutTreeNodes()) {
std::unordered_map<NodeId, size_t>::const_iterator it =
- dom_tree_.node_id_to_index_.find(layout_node->GetBackendNodeId());
- if (it == dom_tree_.node_id_to_index_.end())
- continue;
-
+ dom_tree_.node_id_to_index_.find(layout_node->GetNodeId());
+ DCHECK(it != dom_tree_.node_id_to_index_.end());
dom_tree_.layout_tree_nodes_.push_back(layout_node.get());
}
}
« no previous file with comments | « no previous file | headless/public/util/dom_tree_extractor_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698