third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html - Issue 2455613002: Fix index used to join results of DOM.getDocument and CSS.getLayoutTreeAndStyles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html

Issue 2455613002: Fix index used to join results of DOM.getDocument and CSS.getLayoutTreeAndStyles (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/public/util/dom_tree_extractor_browsertest.cc ('k') | third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes-expected.txt » ('j') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html b/third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html

index 7768b34857061ec68b95bfe68797c7d8affba6e2..94d9f00a46c5ae75fe754794f67ca611065a4dd9 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/css/css-getLayoutTreeNodes.html

@@ -12,8 +12,12 @@

function test()

{

InspectorTest.sendCommand("DOM.enable", {});

- var whitelist = ["transform", "transform-origin", "height", "width", "display", "outline-color"];

- InspectorTest.sendCommandOrDie("CSS.getLayoutTreeAndStyles", {"computedStyleWhitelist": whitelist}, onLayoutTreeNodes);

+ InspectorTest.sendCommandOrDie("DOM.getDocument", {"depth": -1}, onDocument);

Sami 2016/10/26 17:15:23 nit: extra space before {"depth"...

alex clarke (OOO till 29th) 2016/10/27 10:51:11 Done.

+ function onDocument(response) {

+ var whitelist = ["transform", "transform-origin", "height", "width", "display", "outline-color"];

+ InspectorTest.sendCommandOrDie("CSS.getLayoutTreeAndStyles", {"computedStyleWhitelist": whitelist}, onLayoutTreeNodes);

+ }

function onLayoutTreeNodes(response)

{