Put fully resolved analysis results (just errors now) into the byte cache.

Put fully resolved analysis results (just errors now) into the byte cache.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/bd594d453f429ac5347ea0275aa18b4fdae3825b

[Brian Wilkerson, 2016-10-26 18:32:11]

lgtm

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:370: AnalysisResult
_computeAnalysisResult(_File file, bool withUnit) {
Document 'withUnit'.

Also, consider making this a named optional parameter (to force documentation at
call sites).

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:371: // If we don't need to the
fully resolved unit, check for a cached result.
"need to the" --> "need the"

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:174: fb.Offset finish(fb.Builder
fbBuilder) {
"fbBuilder" --> "builder"

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:314: fb.Offset finish(fb.Builder
fbBuilder) {
"fbBuilder" --> "builder"

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:64: abstract class
AnalysisDriverResolvedUnit extends base.SummaryClass {
Seems like these classes ought to be in a different library.

[scheglov, 2016-10-26 18:48:41]

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:370: AnalysisResult
_computeAnalysisResult(_File file, bool withUnit) {
On 2016/10/26 18:32:11, Brian Wilkerson wrote:
> Document 'withUnit'.
> 
> Also, consider making this a named optional parameter (to force documentation
at
> call sites).

Done.

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:371: // If we don't need to the
fully resolved unit, check for a cached result.
On 2016/10/26 18:32:11, Brian Wilkerson wrote:
> "need to the" --> "need the"

Done.

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/format.dart (right):

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/format.dart:174: fb.Offset finish(fb.Builder
fbBuilder) {
On 2016/10/26 18:32:11, Brian Wilkerson wrote:
> "fbBuilder" --> "builder"

This file is automatically generated.

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2455573003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:64: abstract class
AnalysisDriverResolvedUnit extends base.SummaryClass {
On 2016/10/26 18:32:11, Brian Wilkerson wrote:
> Seems like these classes ought to be in a different library.

Possibly.
For now we reuse the flat buffers generating infrastructure for all
serialization - summaries, index, and now analysis.

[scheglov, 2016-10-26 18:48:54]

Description was changed from

==========
Put fully resolved analysis results (just errors now) into the byte cache.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Put fully resolved analysis results (just errors now) into the byte cache.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/bd594d453f429ac5347ea0275aa18b4fdae3825b
==========

[scheglov, 2016-10-26 18:48:56]

Committed patchset #2 (id:20001) manually as
bd594d453f429ac5347ea0275aa18b4fdae3825b (presubmit successful).

[Paul Berry, 2016-10-31 17:02:53]

https://codereview.chromium.org/2455573003/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2455573003/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:387: if (!withUnit) {
AFAICT this block will never execute, since the same effect is already achieved
by lines 375-380.

[scheglov, 2016-10-31 17:07:07]

https://codereview.chromium.org/2455573003/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2455573003/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:387: if (!withUnit) {
On 2016/10/31 17:02:53, Paul Berry wrote:
> AFAICT this block will never execute, since the same effect is already
achieved
> by lines 375-380.

Both this block and the block in lines 375-380 uses the current dependency hash.
But if the dependency hash is not in _dependencySignatureMap, then
_getCachedAnalysisResult(file) will return null. Call to
_createLibraryContext(file) recomputes the dependency hash and puts it into
_dependencySignatureMap. So, this block might still be able to find a previous
result for the newly computed dependency hash.

[Paul Berry, 2016-10-31 21:35:34]

https://codereview.chromium.org/2455573003/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2455573003/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:387: if (!withUnit) {
On 2016/10/31 17:07:06, scheglov wrote:
> On 2016/10/31 17:02:53, Paul Berry wrote:
> > AFAICT this block will never execute, since the same effect is already
> achieved
> > by lines 375-380.
> 
> Both this block and the block in lines 375-380 uses the current dependency
hash.
> But if the dependency hash is not in _dependencySignatureMap, then
> _getCachedAnalysisResult(file) will return null. Call to
> _createLibraryContext(file) recomputes the dependency hash and puts it into
> _dependencySignatureMap. So, this block might still be able to find a previous
> result for the newly computed dependency hash.

Ok, I understand now.  Thanks.