Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2455553002: media: media_unittests also run media mojo unittests (Closed)

Created:
4 years, 1 month ago by xhwang
Modified:
4 years, 1 month ago
Reviewers:
watk, jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review), Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: media_unittests also run media mojo unittests Add media mojo unittests to media_unittets target, so that on bots we don't need to specify multiple smaller media unittests targets. This reverts commit 55b05c7a4c6722911ee2c715ed3a519da8d12315 and partially reverts commit f69024d1ddb7ee6b001203b13a019b6fc9dc7746. "media_mojo_unittests" target is still available to be built and run locally. BUG=656112 Committed: https://crrev.com/b0f8651858496747ff39236c22ec64a7b5037117 Cr-Commit-Position: refs/heads/master@{#428088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -396 lines) Patch
M media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.full.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 39 chunks +0 lines, -228 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.memory.full.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
xhwang
watk: Please OWNERS review media/ changes. jam: Please OWNERS review testing/buildbot changes.
4 years, 1 month ago (2016-10-26 16:41:25 UTC) #6
watk
lgtm
4 years, 1 month ago (2016-10-26 19:07:14 UTC) #9
jam
lgtm
4 years, 1 month ago (2016-10-26 21:08:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455553002/1
4 years, 1 month ago (2016-10-27 04:43:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/249722) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-10-27 06:12:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455553002/1
4 years, 1 month ago (2016-10-27 17:10:24 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 18:35:47 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:01:35 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0f8651858496747ff39236c22ec64a7b5037117
Cr-Commit-Position: refs/heads/master@{#428088}

Powered by Google App Engine
This is Rietveld 408576698