Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: infra/bots/recipes/upload_dm_results.py

Issue 2455523004: Fix recipes for Gerrit property rename (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipes/upload_dm_results.py
diff --git a/infra/bots/recipes/upload_dm_results.py b/infra/bots/recipes/upload_dm_results.py
index 4298b70efcfcf1ca732d9e8e2686efc83a2bad54..dffcc923d9b435840f8323964e74032b7b88fc49 100644
--- a/infra/bots/recipes/upload_dm_results.py
+++ b/infra/bots/recipes/upload_dm_results.py
@@ -88,8 +88,8 @@ def RunSteps(api):
patchset = str(api.properties.get('patchset', ''))
if (api.properties.get('patch_storage', '') == 'gerrit' and
api.properties.get('nobuildbot', '') != 'True'):
- issue = str(api.properties['event.change.number'])
- patchset = str(api.properties['event.patchSet.ref']).split('/')[-1]
+ issue = str(api.properties['patch_issue'])
+ patchset = str(api.properties['patch_ref']).split('/')[-1]
if issue and patchset:
summary_dest_path = '/'.join((
'trybot', summary_dest_path, issue, patchset))
@@ -139,17 +139,16 @@ def GenTests(api):
patchset='1002')
)
- gerrit_kwargs = {
- 'patch_storage': 'gerrit',
- 'repository': 'skia',
- 'event.patchSet.ref': 'refs/changes/00/2100/2',
- 'event.change.number': '2100',
- }
yield (
api.test('recipe_with_gerrit_patch') +
api.properties(
buildername=builder,
revision='abc123',
path_config='kitchen',
- **gerrit_kwargs)
+ patch_storage='gerrit') +
+ api.properties.tryserver(
+ buildername=builder,
+ gerrit_project='skia',
+ gerrit_url='https://skia-review.googlesource.com/',
+ )
)

Powered by Google App Engine
This is Rietveld 408576698