Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: infra/bots/recipes/swarm_test.py

Issue 2455523004: Fix recipes for Gerrit property rename (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipes/swarm_test.py
diff --git a/infra/bots/recipes/swarm_test.py b/infra/bots/recipes/swarm_test.py
index a84de4624b041d9e01c3412f5f98c03d463782ff..24c95182f2aff36199c43ed1824ff317a105d142 100644
--- a/infra/bots/recipes/swarm_test.py
+++ b/infra/bots/recipes/swarm_test.py
@@ -677,12 +677,6 @@ def GenTests(api):
)
builder = 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot'
- gerrit_kwargs = {
- 'patch_storage': 'gerrit',
- 'repository': 'skia',
- 'event.patchSet.ref': 'refs/changes/00/2100/2',
- 'event.change.number': '2100',
- }
yield (
api.test('recipe_with_gerrit_patch') +
api.properties(
@@ -693,7 +687,12 @@ def GenTests(api):
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]',
revision='abc123',
- **gerrit_kwargs)
+ patch_storage='gerrit') +
+ api.properties.tryserver(
+ buildername=builder,
+ gerrit_project='skia',
+ gerrit_url='https://skia-review.googlesource.com/',
+ )
)
yield (
@@ -707,7 +706,12 @@ def GenTests(api):
swarm_out_dir='[SWARM_OUT_DIR]',
revision='abc123',
nobuildbot='True',
- **gerrit_kwargs) +
+ patch_storage='gerrit') +
+ api.properties.tryserver(
+ buildername=builder,
+ gerrit_project='skia',
+ gerrit_url='https://skia-review.googlesource.com/',
+ ) +
api.step_data('get swarming bot id',
stdout=api.raw_io.output('skia-bot-123')) +
api.step_data('get swarming task id', stdout=api.raw_io.output('123456'))
« no previous file with comments | « infra/bots/recipes/swarm_perf.expected/nobuildbot.json ('k') | infra/bots/recipes/swarm_test.expected/nobuildbot.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698