chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java - Issue 2455513004: [Payments] Fix the Payment Request histogram check failure in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java

Issue 2455513004: [Payments] Fix the Payment Request histogram check failure in tests. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java

index 8b1c621aff4081c87d67db629d97bf83a3439269..26953f83ddd962458d841a27d4f9aba131d97ae6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java

@@ -15,7 +15,8 @@ public class PaymentRequestJourneyLogger {

public static final int SECTION_SHIPPING_ADDRESS = 2;

public static final int SECTION_MAX = 3;

- private static final int MIN_EXPECTED_SAMPLE = 0;

+ // The min has to be set to 1 even though we can log 0.

please use gerrit instead 2016/10/26 22:01:14 Please explain why min has to be 1 and why can log

sebsg 2016/10/26 23:42:03 Please tell me if this is more clear. I'm making a

+ private static final int MIN_EXPECTED_SAMPLE = 1;

private static final int MAX_EXPECTED_SAMPLE = 49;

private static final int NUMBER_BUCKETS = 50;