chromeos: Make enterprise help dialog work in mash, part 1

chromeos: Make enterprise help dialog work in mash, part 1

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

This eliminates the last use of GetNativeWindow in SystemTrayDelegateChromeos.

Also clean up some include-what-you-use violations.

TODO: Convert system tray enterprise delegate methods to a mojo interface.

BUG=647412
TEST=chrome browser_tests. Also, on enterprise enrolled device at the lock
screen click on system tray "This device is managed by..." item and verify
that the help dialog appears on top of the login pods.

Committed: https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933
Cr-Commit-Position: refs/heads/master@{#427835}

[James Cook, 2016-10-26 17:57:24]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-10-26 17:58:08]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2016-10-26 17:58:09]

xiyuan, please take a look.

https://codereview.chromium.org/2455513003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/login_web_dialog.cc (right):

https://codereview.chromium.org/2455513003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/login_web_dialog.cc:70:
SystemTrayClient::GetDialogParentContainerId(), browser_context_, this);
Aside: I would like to move GetDialogParentContainerId() to a utility file, but
that would require moving GetUserLoginState() as well, and I'd prefer to wait on
that until the login service is better defined.

[commit-bot: I haz the power, 2016-10-26 17:58:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 18:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:42:22]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-10-26 19:30:07]

lgtm

https://codereview.chromium.org/2455513003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/login_web_dialog.cc (right):

https://codereview.chromium.org/2455513003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/login_web_dialog.cc:70:
SystemTrayClient::GetDialogParentContainerId(), browser_context_, this);
On 2016/10/26 17:58:09, James Cook wrote:
> Aside: I would like to move GetDialogParentContainerId() to a utility file,
but
> that would require moving GetUserLoginState() as well, and I'd prefer to wait
on
> that until the login service is better defined.

Acknowledged.

[James Cook, 2016-10-26 19:33:39]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-10-26 19:33:40]

stevenjb, can I get OWNERS for c/b/ui/ash ?

[stevenjb, 2016-10-26 19:39:07]

lgtm!

https://codereview.chromium.org/2455513003/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (left):

https://codereview.chromium.org/2455513003/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:847: }
Hooray!

[James Cook, 2016-10-26 20:51:02]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:51:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:59:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 22:03:32]

Description was changed from

==========
chromeos: Make enterprise help dialog work in mash, part 1

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

This eliminates the last use of GetNativeWindow in SystemTrayDelegateChromeos.

Also clean up some include-what-you-use violations.

TODO: Convert system tray enterprise delegate methods to a mojo interface.

BUG=647412
TEST=chrome browser_tests. Also, on enterprise enrolled device at the lock
screen click on system tray "This device is managed by..." item and verify
that the help dialog appears on top of the login pods.
==========

to

==========
chromeos: Make enterprise help dialog work in mash, part 1

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

This eliminates the last use of GetNativeWindow in SystemTrayDelegateChromeos.

Also clean up some include-what-you-use violations.

TODO: Convert system tray enterprise delegate methods to a mojo interface.

BUG=647412
TEST=chrome browser_tests. Also, on enterprise enrolled device at the lock
screen click on system tray "This device is managed by..." item and verify
that the help dialog appears on top of the login pods.

Committed: https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933
Cr-Commit-Position: refs/heads/master@{#427835}
==========

[commit-bot: I haz the power, 2016-10-26 22:03:33]

Patchset 1 (id:??) landed as
https://crrev.com/4f58a16098b5f14112db1314c6751a8d8715a933
Cr-Commit-Position: refs/heads/master@{#427835}