Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2455503006: Revert of Merged: [turbofan] Fix typing rule for Math.sign. (Closed)

Created:
4 years, 1 month ago by Michael Hablich
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Revert of Merged: [turbofan] Fix typing rule for Math.sign. (patchset #1 id:1 of https://codereview.chromium.org/2451283004/ ) Reason for revert: Breaks tests: https://chromegw.corp.google.com/i/client.v8.branches/builders/V8%20Linux%20-%20stable%20branch/builds/229/steps/Check/logs/regress-math-sign-nan.. Original issue's description: > Merged: [turbofan] Fix typing rule for Math.sign. > > Revision: 25504a220f75f88b565cf36df73c00e5f2702c65 > > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=ishell@chromium.org > BUG=chromium:658114 > > Committed: https://chromium.googlesource.com/v8/v8/+/cac06c728dbc504464265ba15e7752699e21042d TBR=ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:658114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-cache.h View 1 chunk +1 line, -3 lines 0 comments Download
D test/mjsunit/compiler/regress-math-sign-nan-type.js View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Hablich
Created Revert of Merged: [turbofan] Fix typing rule for Math.sign.
4 years, 1 month ago (2016-10-27 14:08:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455503006/1
4 years, 1 month ago (2016-10-27 14:08:47 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 14:09:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698