Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: components/history/core/browser/web_history_service.cc

Issue 2455503004: [MD History] Fix deletion in heavily scrolled list. (Closed)
Patch Set: add test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/web_history_service.cc
diff --git a/components/history/core/browser/web_history_service.cc b/components/history/core/browser/web_history_service.cc
index e707225b156c03e5f0a913ec091bd27a9a0b0328..abe202c87cdbc5dddefc9b56086533918efb5802 100644
--- a/components/history/core/browser/web_history_service.cc
+++ b/components/history/core/browser/web_history_service.cc
@@ -563,13 +563,14 @@ void WebHistoryService::ExpireHistoryCompletionCallback(
if (response_value)
response_value->GetString("version_info", &server_version_info_);
}
- callback.Run(response_value.get() && success);
// Inform the observers about the history deletion.
if (response_value.get() && success) {
for (WebHistoryServiceObserver& observer : observer_list_)
observer.OnWebHistoryDeleted();
}
+
+ callback.Run(response_value.get() && success);
}
void WebHistoryService::AudioHistoryCompletionCallback(

Powered by Google App Engine
This is Rietveld 408576698