Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2455503004: [MD History] Fix deletion in heavily scrolled list. (Closed)
Patch Set: add test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/browsing_history_handler.h" 5 #include "chrome/browser/ui/webui/browsing_history_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 992 matching lines...) Expand 10 before | Expand all | Expand 10 after
1003 history::HistoryService* history_service, 1003 history::HistoryService* history_service,
1004 bool all_history, 1004 bool all_history,
1005 bool expired, 1005 bool expired,
1006 const history::URLRows& deleted_rows, 1006 const history::URLRows& deleted_rows,
1007 const std::set<GURL>& favicon_urls) { 1007 const std::set<GURL>& favicon_urls) {
1008 if (all_history || DeletionsDiffer(deleted_rows, urls_to_be_deleted_)) 1008 if (all_history || DeletionsDiffer(deleted_rows, urls_to_be_deleted_))
1009 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted"); 1009 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted");
1010 } 1010 }
1011 1011
1012 void BrowsingHistoryHandler::OnWebHistoryDeleted() { 1012 void BrowsingHistoryHandler::OnWebHistoryDeleted() {
1013 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted"); 1013 if (!has_pending_delete_request_)
msramek 2016/11/07 15:45:20 It's possible that OnWebHistoryDeleted() was calle
1014 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted");
1014 } 1015 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/browsing_history_handler.h ('k') | chrome/browser/ui/webui/browsing_history_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698