Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2455463004: [ios] Fixed SSL Interstitial reload. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed SSL Interstitial reload. Do not reload inside IOSSSLErrorHandler::InterstitialWasDismissed to avoid extra reloads. InterstitialWasDismissed is called in the following cases: 1.) Reload button tapped (no need for the second reload) 2.) Back button tapped (no need to reload, going back is enough) 3.) Tab closed (no need to reload closed tab) 4.) "Back to safety" button tapped (reload is actually needed in this case, but it can be done in WebInterstitialImpl::DontProceed). BUG=653963 TEST=dismissing SSL interstitial works correctly Committed: https://crrev.com/e03704ed88b7bac54c067e2b13ef52bf8eb5fe9a Cr-Commit-Position: refs/heads/master@{#427889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ios/chrome/browser/ssl/ios_ssl_error_handler.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-10-26 21:37:45 UTC) #7
kkhorimoto
4 years, 1 month ago (2016-10-27 00:15:11 UTC) #8
kkhorimoto
lgtm
4 years, 1 month ago (2016-10-27 00:15:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455463004/1
4 years, 1 month ago (2016-10-27 00:15:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 00:21:12 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 00:23:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e03704ed88b7bac54c067e2b13ef52bf8eb5fe9a
Cr-Commit-Position: refs/heads/master@{#427889}

Powered by Google App Engine
This is Rietveld 408576698