Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 24554002: dbus: Replace PostTaskTo*Thread methods with Get*TaskRunner (Closed)

Created:
7 years, 2 months ago by hashimoto
Modified:
7 years, 2 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

dbus: Replace PostTaskTo*Thread methods with Get*TaskRunner By exposing TaskRunners, we'll be able to use utility functions like base::PostTaskAndReplyWithResult BUG=None TEST=git cl try R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225324

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -202 lines) Patch
M chromeos/dbus/blocking_method_caller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 5 chunks +22 lines, -11 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M dbus/bus.h View 2 chunks +6 lines, -26 lines 0 comments Download
M dbus/bus.cc View 14 chunks +48 lines, -87 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M dbus/exported_object.cc View 5 chunks +27 lines, -25 lines 0 comments Download
M dbus/mock_bus.h View 1 chunk +2 lines, -10 lines 0 comments Download
M dbus/object_proxy.cc View 11 chunks +29 lines, -27 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
7 years, 2 months ago (2013-09-25 10:25:23 UTC) #1
satorux1
LGTM. this is a good idea.
7 years, 2 months ago (2013-09-26 01:10:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/24554002/3001
7 years, 2 months ago (2013-09-26 02:20:03 UTC) #3
hashimoto
7 years, 2 months ago (2013-09-26 04:32:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r225324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698