MD Downloads: reduce the size of the ellided, displayed download URL

MD Downloads: reduce the size of the ellided, displayed download URL

R=alancutter@chromium.org
BUG=659636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539
Cr-Commit-Position: refs/heads/master@{#428587}

[Dan Beam, 2016-10-28 23:35:30]

Description was changed from

==========
MD Downloads: reduce the size of the ellided, displayed download URL

R=alancutter@chromium.org
BUG=659636
==========

to

==========
MD Downloads: reduce the size of the ellided, displayed download URL

R=alancutter@chromium.org
BUG=659636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-28 23:37:21]

we really gotta optimize text-overflow, but agreed that shoving 2MB of string
into it ain't that sane either

[Dan Beam, 2016-10-28 23:37:27]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 23:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 00:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 00:37:55]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-29 00:53:15]

dpapad@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-10-29 00:53:15]

lgtm

https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.js:87: chopString_: function(text,
maxLength) {
Nit (optional): Perhaps don't bother passing the maxLength as a param since
currently only one value is ever passed.

[Dan Beam, 2016-10-29 01:00:52]

https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/item.js:87: chopString_: function(text,
maxLength) {
On 2016/10/29 00:53:15, dpapad wrote:
> Nit (optional): Perhaps don't bother passing the maxLength as a param since
> currently only one value is ever passed.

Done.

[Dan Beam, 2016-10-29 01:00:55]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-10-29 01:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2455393004/#ps20001
(title: "she's choppin, she's choppin, brocoooooooollliiiiiii")

[commit-bot: I haz the power, 2016-10-29 01:01:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 01:54:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-29 02:01:39]

Description was changed from

==========
MD Downloads: reduce the size of the ellided, displayed download URL

R=alancutter@chromium.org
BUG=659636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: reduce the size of the ellided, displayed download URL

R=alancutter@chromium.org
BUG=659636
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539
Cr-Commit-Position: refs/heads/master@{#428587}
==========

[commit-bot: I haz the power, 2016-10-29 02:01:40]

Patchset 2 (id:??) landed as
https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539
Cr-Commit-Position: refs/heads/master@{#428587}