Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2455393004: MD Downloads: reduce the size of the ellided, displayed download URL (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
CC:
arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-downloads_chromium.org, esprehn, michaelpg+watch-md-ui_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: reduce the size of the ellided, displayed download URL R=alancutter@chromium.org BUG=659636 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539 Cr-Commit-Position: refs/heads/master@{#428587}

Patch Set 1 #

Total comments: 2

Patch Set 2 : she's choppin, she's choppin, brocoooooooollliiiiiii #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_downloads/layout_tests.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
we really gotta optimize text-overflow, but agreed that shoving 2MB of string into it ain't ...
4 years, 1 month ago (2016-10-28 23:37:21 UTC) #2
dpapad
lgtm https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md_downloads/item.js File chrome/browser/resources/md_downloads/item.js (right): https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md_downloads/item.js#newcode87 chrome/browser/resources/md_downloads/item.js:87: chopString_: function(text, maxLength) { Nit (optional): Perhaps don't ...
4 years, 1 month ago (2016-10-29 00:53:15 UTC) #8
Dan Beam
https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md_downloads/item.js File chrome/browser/resources/md_downloads/item.js (right): https://codereview.chromium.org/2455393004/diff/1/chrome/browser/resources/md_downloads/item.js#newcode87 chrome/browser/resources/md_downloads/item.js:87: chopString_: function(text, maxLength) { On 2016/10/29 00:53:15, dpapad wrote: ...
4 years, 1 month ago (2016-10-29 01:00:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455393004/20001
4 years, 1 month ago (2016-10-29 01:01:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-29 01:54:57 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 02:01:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539
Cr-Commit-Position: refs/heads/master@{#428587}

Powered by Google App Engine
This is Rietveld 408576698