PS - Adjusting webRequest API for use in Public Sessions

chrome/browser/extensions/api/web_request/web_request_apitest.cc

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
index a0ea8893dbb2911fa26c903b486acdc2f6c2ae45..9728c9704aa781f80341220927289ab2abd00593 100644
--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
@@ -22,6 +22,7 @@
 #include "chrome/common/extensions/extension_process_policy.h"
 #include "chrome/test/base/search_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "chromeos/login/login_state.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_view_host.h"
@@ -161,6 +162,23 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestTypes) {
   ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_types.html")) << message_;
 }
 
+#if defined(OS_CHROMEOS)
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestPublicSession) {
+  ASSERT_TRUE(StartEmbeddedTestServer());
+  // Set Public Session state.
+  chromeos::LoginState::Get()->SetLoggedInState(
+      chromeos::LoginState::LOGGED_IN_ACTIVE,
+      chromeos::LoginState::LOGGED_IN_USER_PUBLIC_ACCOUNT);
+  // Disable a CHECK while doing api tests.
+  WebRequestPermissions::AllowAllExtensionLocationsInPublicSessionForTesting(
+      true);
+  ASSERT_TRUE(RunExtensionSubtest("webrequest_public_session", "test.html")) <<
+      message_;
+  WebRequestPermissions::AllowAllExtensionLocationsInPublicSessionForTesting(

[Ivan Šandrk, 2016/11/15 13:49:58]

QQ - Does each test run from a clean state or is some part of state kept between
tests? I guess I can drop this line if each test is clean.

[Devlin, 2016/11/15 15:12:02]

Short answer: depends on the test and the state you are referring to.  Keep this
line. :)

Longer answer: Browser tests do a complete tear down/re set up after each test,
which would clear this bit.  However, that's only because we don't run multiple
browser tests in the same process for now, which we do for unit tests.  So if
this were a unit test, this line *would* be strictly necessary.  To make it more
confusing, unittesting has a bit of state reset between tests, namely the
command line, because so many unittests mangle it.

+      false);
+}
+#endif  // defined(OS_CHROMEOS)
+
 // Test that a request to an OpenSearch description document (OSDD) generates
 // an event with the expected details.
 IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestTestOSDD) {