Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: extensions/browser/api/web_request/web_request_permissions.cc

Issue 2455393002: PS - Adjusting webRequest API for use in Public Sessions (Closed)
Patch Set: Updated code Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_permissions.cc
diff --git a/extensions/browser/api/web_request/web_request_permissions.cc b/extensions/browser/api/web_request/web_request_permissions.cc
index c4ac79580cec811af010da24ee14d79d50018e26..d306a22941a388e0a07cb3c625fd054ad35c564f 100644
--- a/extensions/browser/api/web_request/web_request_permissions.cc
+++ b/extensions/browser/api/web_request/web_request_permissions.cc
@@ -6,6 +6,7 @@
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
+#include "chromeos/login/login_state.h"
#include "content/public/browser/resource_request_info.h"
#include "extensions/browser/extension_navigation_ui_data.h"
#include "extensions/browser/guest_view/web_view/web_view_renderer_state.h"
@@ -109,6 +110,9 @@ bool WebRequestPermissions::HideRequest(
}
// static
+bool WebRequestPermissions::allow_all_extensions_in_public_sessions_ = false;
+
+// static
PermissionsData::AccessType WebRequestPermissions::CanExtensionAccessURL(
const extensions::InfoMap* extension_info_map,
const std::string& extension_id,
@@ -125,6 +129,20 @@ PermissionsData::AccessType WebRequestPermissions::CanExtensionAccessURL(
if (!extension)
return PermissionsData::ACCESS_DENIED;
+ // When we are in a Public Session, allow all URLs for webRequests initiated
+ // by a regular extension.
+#if defined(OS_CHROMEOS)
+ if (chromeos::LoginState::IsInitialized() &&
+ chromeos::LoginState::Get()->IsPublicSessionUser() &&
+ extension->is_extension()) {
+ // Make sure that the extension is truly installed by policy (the assumption
+ // in Public Session is that all extensions are installed by policy).
+ CHECK(allow_all_extensions_in_public_sessions_ ||
+ extensions::Manifest::IsPolicyLocation(extension->location()));
+ return PermissionsData::ACCESS_ALLOWED;
+ }
+#endif
+
// Check if this event crosses incognito boundaries when it shouldn't.
if (crosses_incognito && !extension_info_map->CanCrossIncognito(extension))
return PermissionsData::ACCESS_DENIED;

Powered by Google App Engine
This is Rietveld 408576698