PS - Adjusting webRequest API for use in Public Sessions

chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc

Index: chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7298169f690cc7abec0f211f3edf75dd056e8648
--- /dev/null
+++ b/chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc
@@ -0,0 +1,66 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[Devlin, 2016/11/14 17:44:38]

no (c)

[Ivan Šandrk, 2016/11/14 20:16:13]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/api/web_request/web_request_event_details.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+TEST(WebRequestEventDetailsTest, WhitelistedCopyForPublicSession) {
+  // Create the original instance and populate it with some values.
+  std::unique_ptr<WebRequestEventDetails> orig(new WebRequestEventDetails);
+
+  orig->render_process_id_ = 1;
+  orig->render_frame_id_ = 2;
+  orig->extra_info_spec_ = 3;
+
+  orig->request_body_.reset(new base::DictionaryValue);
+  orig->request_headers_.reset(new base::ListValue);
+  orig->response_headers_.reset(new base::ListValue);
+
+  const char* const safe_attributes[] = {
+    "method", "requestId", "timeStamp", "type", "tabId", "frameId",
+    "parentFrameId", "fromCache", "error", "ip", "statusLine", "statusCode"
+  };
+
+  for (const char* safe_attr : safe_attributes) {
+    orig->dict_.SetString(safe_attr, safe_attr);
+  }
+
+  orig->dict_.SetString("url", "http://www.foo.bar/baz");
+
+  // Add some extra dict_ values that should be filtered out.
+  orig->dict_.SetString("foo", "foo value");

[Devlin, 2016/11/14 17:44:38]

I'd prefer we stick to values that might be set - otherwise if we ever add
validation code, this will fail.

[Ivan Šandrk, 2016/11/14 20:16:13]

Done.

+  orig->dict_.SetString("bar", "bar value");
+
+  // Make a copy and check that filtering works.
+  std::unique_ptr<WebRequestEventDetails> copy(
+      orig->WhitelistedCopyForPublicSession());
+
+  EXPECT_EQ(copy->render_process_id_, orig->render_process_id_);
+  EXPECT_EQ(copy->render_frame_id_, orig->render_frame_id_);
+  EXPECT_EQ(copy->extra_info_spec_, 0);

[Devlin, 2016/11/14 17:44:38]

EXPECT_EQ(expected, actual)

[Ivan Šandrk, 2016/11/14 20:16:13]

Done.

+
+  EXPECT_EQ(copy->request_body_, nullptr);
+  EXPECT_EQ(copy->request_headers_, nullptr);
+  EXPECT_EQ(copy->response_headers_, nullptr);
+
+  for (const char* safe_attr : safe_attributes) {
+    std::string copy_str, orig_str;
+    copy->dict_.GetString(safe_attr, &copy_str);
+    orig->dict_.GetString(safe_attr, &orig_str);
+    EXPECT_EQ(copy_str, orig_str);
+  }
+
+  // URL is stripped down to origin.
+  std::string url;
+  copy->dict_.GetString("url", &url);
+  EXPECT_EQ(url, "http://www.foo.bar/");
+
+  // Extras are filtered out (+1 for url).
+  EXPECT_EQ(copy->dict_.size(), arraysize(safe_attributes) + 1);
+}
+
+}  // namespace extensions