Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Side by Side Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2455393002: PS - Adjusting webRequest API for use in Public Sessions (Closed)
Patch Set: webRequest and webRequestBlocking are safe permissions now Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h" 5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cstddef> 9 #include <cstddef>
10 #include <string> 10 #include <string>
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 657
658 // Admin controls network config anyways. 658 // Admin controls network config anyways.
659 "vpnProvider", 659 "vpnProvider",
660 660
661 // Just UX. 661 // Just UX.
662 "wallpaper", 662 "wallpaper",
663 663
664 // Privacy sensitive URL access. 664 // Privacy sensitive URL access.
665 // "webNavigation", 665 // "webNavigation",
666 666
667 // Provides access to cookies and form upload data. Options: (1) block, 667 // Sensitive content is stripped away.
668 // (2) strip all content in events. 668 "webRequest",
669 // "webRequest", 669 "webRequestBlocking",
670
671 // Fine once webRequest is adjusted.
672 // "webRequestBlocking",
673 670
674 // This allows content scripts and capturing. However, the webview runs 671 // This allows content scripts and capturing. However, the webview runs
675 // within a separate storage partition, i.e. doesn't share cookies and other 672 // within a separate storage partition, i.e. doesn't share cookies and other
676 // storage with the browsing session. Furthermore, the embedding app could 673 // storage with the browsing session. Furthermore, the embedding app could
677 // just as well proxy 3rd-party origin content through its own web origin 674 // just as well proxy 3rd-party origin content through its own web origin
678 // server-side or via chrome.socket. Finally, web security doesn't make a 675 // server-side or via chrome.socket. Finally, web security doesn't make a
679 // lot of sense when there's no URL bar or HTTPS padlock providing trusted 676 // lot of sense when there's no URL bar or HTTPS padlock providing trusted
680 // UI. Bottom line: Risks are mitigated, further restrictions don't make 677 // UI. Bottom line: Risks are mitigated, further restrictions don't make
681 // sense, so OK to allow. 678 // sense, so OK to allow.
682 "webview", 679 "webview",
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
936 if (error) { 933 if (error) {
937 *error = l10n_util::GetStringFUTF16( 934 *error = l10n_util::GetStringFUTF16(
938 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT, 935 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT,
939 base::UTF8ToUTF16(extension->name()), 936 base::UTF8ToUTF16(extension->name()),
940 base::UTF8ToUTF16(extension->id())); 937 base::UTF8ToUTF16(extension->id()));
941 } 938 }
942 return false; 939 return false;
943 } 940 }
944 941
945 } // namespace chromeos 942 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698