PS - Adjusting webRequest API for use in Public Sessions

extensions/browser/api/web_request/web_request_permissions.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_PERMISSIONS_H_
 #define EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_PERMISSIONS_H_
 
 #include <map>
 #include <string>
 
@@ skipping 31 matching lines @@
   // |url|.
   static extensions::PermissionsData::AccessType CanExtensionAccessURL(
       const extensions::InfoMap* extension_info_map,
       const std::string& extension_id,
       const GURL& url,
       int tab_id,
       bool crosses_incognito,
       HostPermissionsCheck host_permissions_check);
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(ExtensionWebRequestApiTest, WebRequestPublicSession);
+
+  static bool allow_all_extensions_in_public_sessions_;

[Ivan Šandrk, 2016/11/14 20:16:13]

Added the runtime bool like this, but I'm unable to access it from the apitest
(... is a private member of WebRequestPermissions). Also tried using a private
setter function to no avail. Help?

[Devlin, 2016/11/15 01:19:37]

Hmm... I can't think of why that would be - it seems like this should work. 
I'll try patching it in locally tomorrow to take a look.

[Ivan Šandrk, 2016/11/15 13:49:58]

Got it working in a bit different way (suggestion by Drew). It seems that
functions ending with "ForTesting" generate presubmit warnings if called from
non-testing code :-)

+
   DISALLOW_IMPLICIT_CONSTRUCTORS(WebRequestPermissions);
 };
 
 #endif  // EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_PERMISSIONS_H_