chrome/test/data/extensions/api_test/webrequest_public_session/manifest.json - Issue 2455393002: PS - Adjusting webRequest API for use in Public Sessions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/webrequest_public_session/manifest.json

Issue 2455393002: PS - Adjusting webRequest API for use in Public Sessions (Closed)

Patch Set: Fixed unittest error Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "webRequest",

	3 "version": "1.0",

	4 "manifest_version": 2,

	5 "description": "Tests the webRequest API in Public Session.",

	6 "permissions": ["webRequest", "webRequestBlocking", "tabs",
	Devlin 2016/11/14 17:44:38 We shouldn't need tabs and declarativeWebRequest, We shouldn't need tabs and declarativeWebRequest, right? Ivan Šandrk 2016/11/14 20:16:13 I copied over webrequest/framework.js which uses t Show quoted text On 2016/11/14 17:44:38, Devlin wrote: > We shouldn't need tabs and declarativeWebRequest, right? I copied over webrequest/framework.js which uses them both. I believe it needs the tab permission for running the tests, but now I see that I can take away the declarativeWebRequest. EDIT: Doesn't work without the declarativeWebRequest, even after removing it from framework.js. I don't think I would want to spend time investigating why at this point. I hope you're fine with it as is.
	7 "declarativeWebRequest"]

	8 }

OLD	NEW