Add implicit trailing dot domain matching support to URLPattern.

extensions/common/url_pattern_unittest.cc

Index: extensions/common/url_pattern_unittest.cc
diff --git a/extensions/common/url_pattern_unittest.cc b/extensions/common/url_pattern_unittest.cc
index 87ce1a1d7780bd21d4a0ca17744579e2f60849a8..9a2ac5df51f99ac13f5da35d5ed8d6453aa364b5 100644
--- a/extensions/common/url_pattern_unittest.cc
+++ b/extensions/common/url_pattern_unittest.cc
@@ -849,4 +849,19 @@ TEST(ExtensionURLPatternTest, MatchesSingleOrigin) {
           .MatchesSingleOrigin());
 }
 
+TEST(ExtensionURLPatternTest, TrailingDotDomain) {
+  const GURL normal_domain("http://example.com/");
+  const GURL trailing_dot_domain("http://example.com./");
+
+  // Both patterns should match trailing dot and non trailing dot domains.

[Devlin, 2016/10/31 16:13:17]

For those interested in the future, can we add a link to the spec (or other
reputable source) indicating that trailing dots are valid and are equivalent to
the non-trailing dot variant?

[Devlin, 2016/11/01 14:52:14]

Looks like you missed this one.

+  const URLPattern pattern(URLPattern::SCHEME_HTTP, "*://example.com/*");
+  EXPECT_TRUE(pattern.MatchesURL(GURL(normal_domain)));

[Devlin, 2016/10/31 16:13:17]

No need for the GURL() ctor here - we can just pass in normal_domain directly
(same for below).

[Devlin, 2016/11/01 14:52:14]

And this one.

+  EXPECT_TRUE(pattern.MatchesURL(GURL(trailing_dot_domain)));
+
+  const URLPattern trailing_pattern(URLPattern::SCHEME_HTTP,
+                                    "*://example.com./*");
+  EXPECT_TRUE(trailing_pattern.MatchesURL(GURL(normal_domain)));
+  EXPECT_TRUE(trailing_pattern.MatchesURL(GURL(trailing_dot_domain)));
+}
+
 }  // namespace