Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: extensions/common/url_pattern.h

Issue 2455373002: Add implicit trailing dot domain matching support to URLPattern. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/url_pattern.cc » ('j') | extensions/common/url_pattern.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/url_pattern.h
diff --git a/extensions/common/url_pattern.h b/extensions/common/url_pattern.h
index bcdc7f65d5d0e77bbf5203aacf59e53734ee199a..94199ede5edd880a4101e7ccc7bf7cb6cb2b5687 100644
--- a/extensions/common/url_pattern.h
+++ b/extensions/common/url_pattern.h
@@ -222,6 +222,9 @@ class URLPattern {
// equivalent literal schemes, otherwise returns the current scheme.
std::vector<std::string> GetExplicitSchemes() const;
+ // Adds or removes trailing dot to properly handle FQDN matching.
+ std::string CanonicalizeHostForMatching(const GURL& url) const;
+
// A bitmask containing the schemes which are considered valid for this
// pattern. Parse() uses this to decide whether a pattern contains a valid
// scheme.
« no previous file with comments | « no previous file | extensions/common/url_pattern.cc » ('j') | extensions/common/url_pattern.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698