Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2455323002:
[Mac] Clean up AvatarButtonController (Closed)
|
Created:
4 years, 1 month ago by spqchan Modified:
4 years, 1 month ago Reviewers:
Robert Sesek CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Clean up AvatarButtonController
Checks for Material Design had recently been removed. However,
there's still a lot of leftover code. This CL cleans up
AvatarButtonController so that it will be easier to add new things to it.
BUG=654876
Committed: https://crrev.com/150c941e115f73ac37c7ae2b840d2420f1c6f45e
Cr-Commit-Position: refs/heads/master@{#428395}
Patch Set 1 #Patch Set 2 : nit #Messages
Total messages: 19 (13 generated)
Description was changed from ========== [Mac] Clean up AvatarButtonController Since BUG= ========== to ========== [Mac] Clean up AvatarButtonController Checks for Material Design had been removed recently. However, there's still a lot of unwanted Material and Non-Material code that remains. This CL cleans up the leftovers in AvatarButtonController BUG=654876 ==========
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Mac] Clean up AvatarButtonController Checks for Material Design had been removed recently. However, there's still a lot of unwanted Material and Non-Material code that remains. This CL cleans up the leftovers in AvatarButtonController BUG=654876 ========== to ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up the leftovers in AvatarButtonController. BUG=654876 ==========
Description was changed from ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up the leftovers in AvatarButtonController. BUG=654876 ========== to ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up AvatarButtonController so that it will be easier to add new things to it. BUG=654876 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
lgtm
On 2016/10/28 13:42:50, Robert Sesek wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up AvatarButtonController so that it will be easier to add new things to it. BUG=654876 ========== to ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up AvatarButtonController so that it will be easier to add new things to it. BUG=654876 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up AvatarButtonController so that it will be easier to add new things to it. BUG=654876 ========== to ========== [Mac] Clean up AvatarButtonController Checks for Material Design had recently been removed. However, there's still a lot of leftover code. This CL cleans up AvatarButtonController so that it will be easier to add new things to it. BUG=654876 Committed: https://crrev.com/150c941e115f73ac37c7ae2b840d2420f1c6f45e Cr-Commit-Position: refs/heads/master@{#428395} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/150c941e115f73ac37c7ae2b840d2420f1c6f45e Cr-Commit-Position: refs/heads/master@{#428395} |
