[Sync] Updating all sync components to use similar presubmit linting logic.

components/sync/PRESUBMIT.py

-# Copyright (c) 2016 The Chromium Authors. All rights reserved.
+# Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-"""Presubmit script for sync
-This checks that ModelTypeInfo entries in model_type.cc follow conventions.
-See CheckModelTypeInfoMap or model_type.cc for more detail on the rules.
+"""Presubmit script for sync component.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into depot_tools.
 """
 
 import os
+import re
 
 # Some definitions don't follow all the conventions we want to enforce.
 # It's either difficult or impossible to fix this, so we ignore the problem(s).
 GRANDFATHERED_MODEL_TYPES = [
   'UNSPECIFIED',  # Doesn't have a root tag or notification type.
   'TOP_LEVEL_FOLDER',  # Doesn't have a root tag or notification type.
   'AUTOFILL_WALLET_DATA',  # Root tag and model type string lack DATA suffix.
   'APP_SETTINGS',  # Model type string has inconsistent capitalization.
   'EXTENSION_SETTINGS',  # Model type string has inconsistent capitalization.
   'SUPERVISED_USER_SETTINGS',  # Root tag and model type string replace
@@ skipping 29 matching lines @@
 # in model_type.cc.
 MODEL_TYPE_START_PATTERN = '^const ModelTypeInfo kModelTypeInfoMap'
 MODEL_TYPE_END_PATTERN = '^\};'
 
 # Strings relating to files we'll need to read.
 # model_type.cc is where the ModelTypeInfoMap is
 # sync.proto is where the proto definitions for ModelTypes are.
 PROTO_FILE_PATH = './protocol/sync.proto'
 MODEL_TYPE_FILE_NAME = 'model_type.cc'
 
-
-def CheckChangeOnUpload(input_api, output_api):
-  """Preupload check function required by presubmit convention.
-  See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
-  """
-  for f in input_api.AffectedFiles():
-    if(f.LocalPath().endswith(MODEL_TYPE_FILE_NAME)):
-      return CheckModelTypeInfoMap(input_api, output_api, f)
-  return []
-
-
-def CheckChangeOnCommit(input_api, output_api):
-  """Precommit check function required by presubmit convention.
-  See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
-  """
-  for f in input_api.AffectedFiles():
-    if f.LocalPath().endswith(MODEL_TYPE_FILE_NAME):
-      return CheckModelTypeInfoMap(input_api, output_api, f)
-  return []
-
+SYNC_SOURCE_FILES = (r'^components[\\/]sync[\\/].*\.(cc|h)$',)
 
 def CheckModelTypeInfoMap(input_api, output_api, model_type_file):
   """Checks the kModelTypeInfoMap in model_type.cc follows conventions.
   Checks that the kModelTypeInfoMap follows the below rules:
     1) The model type string should match the model type name, but with
        only the first letter capitalized and spaces instead of underscores.
     2) The root tag should be the same as the model type but all lowercase.
     3) The notification type should match the proto message name.
     4) No duplicate data across model types.
    Args:
@@ skipping 282 matching lines @@
   Args:
     field_number: string representation of a field number enum reference
   Returns:
     A string that is the corresponding proto field data type. e.g.
     FieldNumberToPrototypeString('EntitySpecifics::kAppFieldNumber')
     => 'AppSpecifics'
   """
   return field_number.replace(FIELD_NUMBER_PREFIX, '').replace(
     'FieldNumber', 'Specifics').replace(
     'AppNotificationSpecifics', 'AppNotification')
+
+def CheckChangeLintsClean(input_api, output_api):
+  source_filter = lambda x: input_api.FilterSourceFile(
+    x, white_list=SYNC_SOURCE_FILES, black_list=None)
+
+  return input_api.canned_checks.CheckChangeLintsClean(
+      input_api, output_api, source_filter, lint_filters=[], verbose_level=1)
+
+def CheckChanges(input_api, output_api):
+  results = []
+  results += CheckChangeLintsClean(input_api, output_api)
+  results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
+  for f in input_api.AffectedFiles():
+    if f.LocalPath().endswith(MODEL_TYPE_FILE_NAME):
+      return CheckModelTypeInfoMap(input_api, output_api, f)
+  return results
+
+def CheckChangeOnUpload(input_api, output_api):
+  return CheckChanges(input_api, output_api)
+
+def CheckChangeOnCommit(input_api, output_api):
+  return CheckChanges(input_api, output_api)