Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2455203002: [Sync] Updating all sync components to use similar presubmit linting logic. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Updating all sync components to use similar presubmit linting logic. BUG=660143 Committed: https://crrev.com/0a8b6628809e4faeef649143d00651f28de371b4 Cr-Commit-Position: refs/heads/master@{#428213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -65 lines) Patch
A + components/browser_sync/PRESUBMIT.py View 2 chunks +12 lines, -6 lines 0 comments Download
M components/sync/PRESUBMIT.py View 3 chunks +29 lines, -24 lines 0 comments Download
D components/sync/driver/PRESUBMIT.py View 1 chunk +0 lines, -25 lines 0 comments Download
A + components/sync_bookmarks/PRESUBMIT.py View 2 chunks +13 lines, -6 lines 0 comments Download
M components/sync_sessions/PRESUBMIT.py View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
skym
PTAL. Doesn't add anything for chrome/browser/sync/* because all of chrome/* already has an existing (although ...
4 years, 1 month ago (2016-10-27 20:53:40 UTC) #2
maxbogue
lgtm! bummer there isn't a good way to share it though.
4 years, 1 month ago (2016-10-27 23:16:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455203002/1
4 years, 1 month ago (2016-10-27 23:25:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 23:34:55 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:39:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a8b6628809e4faeef649143d00651f28de371b4
Cr-Commit-Position: refs/heads/master@{#428213}

Powered by Google App Engine
This is Rietveld 408576698