Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2455163002: Prevent AutoscrollForSelection when selecting text in a fixed-position element. (Closed)

Created:
4 years, 1 month ago by majidvp
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Prevent AutoscrollForSelection when selecting text in a fixed-position element. AutoscrollForSelection is triggered when selecting text and dragging mouse out of the container. However, we don't want selecting text in a fixed-position element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find the object is inside a fixed-position element, we should prevent AutoscrollForSelection from happening. BUG=655489 Review-Url: https://codereview.chromium.org/2441683002 Cr-Commit-Position: refs/heads/master@{#427146} (cherry picked from commit 53546e297f782849d9da8004508d0b85c2fd931c) Committed: https://chromium.googlesource.com/chromium/src/+/9021d6508dfddb41393ae8fa2af2e6dae8cac676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/events/autoscroll-disabled-in-fix.html View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
majidvp
4 years, 1 month ago (2016-10-27 18:31:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9021d6508dfddb41393ae8fa2af2e6dae8cac676.

Powered by Google App Engine
This is Rietveld 408576698