Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2455133005: Remove FrameMsg_ClearFocusedFrame. (Closed)

Created:
4 years, 1 month ago by avallee
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameMsg_ClearFocusedFrame. https://codereview.chromium.org/2451143003/ removes the dependency on this message. - Remove FrameMsg_ClearFocusedFrame - Remove WebView::unfocusDocumentView - Remvoe RenderFrame::ClearFocusedFrame BUG=660044 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/4efd8dc094dc1b000c8aa01ffe691e57732a8397 Cr-Commit-Position: refs/heads/master@{#432906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (12 generated)
avallee
PTAL. This depends on the https://codereview.chromium.org/2451143003/ which removes the dependency on ClearFocusedFrame.
4 years, 1 month ago (2016-10-28 19:49:45 UTC) #5
alexmos
Thanks, LGTM once the other CL is good to go.
4 years, 1 month ago (2016-11-01 16:58:40 UTC) #8
dcheng
lgtm (thanks for cleaning this up!)
4 years, 1 month ago (2016-11-01 18:06:16 UTC) #9
Charlie Reis
content/ LGTM
4 years, 1 month ago (2016-11-01 18:14:35 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2451143003 Patch 100001). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-17 02:46:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455133005/1
4 years, 1 month ago (2016-11-17 12:28:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/317045)
4 years, 1 month ago (2016-11-17 16:30:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455133005/1
4 years, 1 month ago (2016-11-17 16:36:17 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 17:49:28 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 18:08:59 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4efd8dc094dc1b000c8aa01ffe691e57732a8397
Cr-Commit-Position: refs/heads/master@{#432906}

Powered by Google App Engine
This is Rietveld 408576698