Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/ui/ash/system_tray_client.cc

Issue 2455113003: MD Settings: Fix Client Navigations to Search Query URLs (Closed)
Patch Set: Fix implementation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/system_tray_client.cc
diff --git a/chrome/browser/ui/ash/system_tray_client.cc b/chrome/browser/ui/ash/system_tray_client.cc
index 946fda056617dfe7d8ec68e20b4aa0622b780200..b25ea01f65132cc65a1603f102ff8c37b342638d 100644
--- a/chrome/browser/ui/ash/system_tray_client.cc
+++ b/chrome/browser/ui/ash/system_tray_client.cc
@@ -25,7 +25,6 @@
#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/common/url_constants.h"
-#include "chrome/grit/generated_resources.h"
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/session_manager_client.h"
#include "chromeos/login/login_state.h"
@@ -34,7 +33,6 @@
#include "net/base/escape.h"
#include "services/service_manager/public/cpp/connector.h"
#include "third_party/cros_system_api/dbus/shill/dbus-constants.h"
-#include "ui/base/l10n/l10n_util.h"
using chromeos::DBusThreadManager;
using chromeos::LoginState;
@@ -140,12 +138,9 @@ void SystemTrayClient::ShowSettings() {
void SystemTrayClient::ShowDateSettings() {
content::RecordAction(base::UserMetricsAction("ShowDateOptions"));
- std::string sub_page =
- std::string(chrome::kSearchSubPage) + "#" +
- l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME);
// Everybody can change the time zone (even though it is a device setting).
chrome::ShowSettingsSubPageForProfile(ProfileManager::GetActiveUserProfile(),
- sub_page);
+ chrome::kDateTimeSubPage);
}
void SystemTrayClient::ShowSetTimeDialog() {
@@ -186,10 +181,7 @@ void SystemTrayClient::ShowAccessibilityHelp() {
void SystemTrayClient::ShowAccessibilitySettings() {
content::RecordAction(base::UserMetricsAction("ShowAccessibilitySettings"));
- std::string sub_page = std::string(chrome::kSearchSubPage) + "#" +
- l10n_util::GetStringUTF8(
- IDS_OPTIONS_SETTINGS_SECTION_TITLE_ACCESSIBILITY);
- ShowSettingsSubPageForActiveUser(sub_page);
+ ShowSettingsSubPageForActiveUser(chrome::kAccessibilitySubPage);
}
void SystemTrayClient::ShowPaletteHelp() {
« no previous file with comments | « chrome/browser/interstitials/chrome_controller_client.cc ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698