third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h - Issue 2455093002: [css-align] Don't resolve 'auto' values for computed style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2455093002: [css-align] Don't resolve 'auto' values for computed style. (Closed)

Patch Set: 'auto' is not valid for justify-items. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

index 31aaa37643a1651dce1a194bb558329126600d37..d4b656799398aedfe230e3ed7862ba153eaf7772 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

@@ -2982,9 +2982,7 @@ inline CSSIdentifierValue::CSSIdentifierValue(ItemPosition item_position)

: CSSValue(kIdentifierClass) {

switch (item_position) {

case kItemPositionAuto:

- // The 'auto' values might have been already resolved.

- NOTREACHED();

- value_id_ = CSSValueNormal;

+ value_id_ = CSSValueAuto;

break;

case kItemPositionNormal:

value_id_ = CSSValueNormal;