Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2455093002: [css-align] Don't resolve 'auto' values for computed style. (Closed)
Patch Set: Patch for landing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 2936 matching lines...) Expand 10 before | Expand all | Expand 10 after
2947 } 2947 }
2948 NOTREACHED(); 2948 NOTREACHED();
2949 return kContentBox; 2949 return kContentBox;
2950 } 2950 }
2951 2951
2952 template <> 2952 template <>
2953 inline CSSIdentifierValue::CSSIdentifierValue(ItemPosition item_position) 2953 inline CSSIdentifierValue::CSSIdentifierValue(ItemPosition item_position)
2954 : CSSValue(kIdentifierClass) { 2954 : CSSValue(kIdentifierClass) {
2955 switch (item_position) { 2955 switch (item_position) {
2956 case kItemPositionAuto: 2956 case kItemPositionAuto:
2957 // The 'auto' values might have been already resolved. 2957 value_id_ = CSSValueAuto;
2958 NOTREACHED();
2959 value_id_ = CSSValueNormal;
2960 break; 2958 break;
2961 case kItemPositionNormal: 2959 case kItemPositionNormal:
2962 value_id_ = CSSValueNormal; 2960 value_id_ = CSSValueNormal;
2963 break; 2961 break;
2964 case kItemPositionStretch: 2962 case kItemPositionStretch:
2965 value_id_ = CSSValueStretch; 2963 value_id_ = CSSValueStretch;
2966 break; 2964 break;
2967 case kItemPositionBaseline: 2965 case kItemPositionBaseline:
2968 value_id_ = CSSValueBaseline; 2966 value_id_ = CSSValueBaseline;
2969 break; 2967 break;
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
3292 default: 3290 default:
3293 break; 3291 break;
3294 } 3292 }
3295 NOTREACHED(); 3293 NOTREACHED();
3296 return kContainsNone; 3294 return kContainsNone;
3297 } 3295 }
3298 3296
3299 } // namespace blink 3297 } // namespace blink
3300 3298
3301 #endif 3299 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698