Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html

Issue 2455093002: [css-align] Don't resolve 'auto' values for computed style. (Closed)
Patch Set: 'auto' is not valid for justify-items. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> 1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="../../resources/js-test.js"></script> 4 <script src="../../resources/js-test.js"></script>
5 </head> 5 </head>
6 <body> 6 <body>
7 <div id="flexbox"> 7 <div id="flexbox">
8 <div id="flexitem"></div> 8 <div id="flexitem"></div>
9 </div> 9 </div>
10 <script> 10 <script>
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 flexbox.style.justifyContent = 'space-between'; 74 flexbox.style.justifyContent = 'space-between';
75 shouldBeEqualToString('flexbox.style.justifyContent', 'space-between'); 75 shouldBeEqualToString('flexbox.style.justifyContent', 'space-between');
76 shouldBeEqualToString('window.getComputedStyle(flexbox, null).justifyContent', ' space-between'); 76 shouldBeEqualToString('window.getComputedStyle(flexbox, null).justifyContent', ' space-between');
77 77
78 flexbox.style.justifyContent = ''; 78 flexbox.style.justifyContent = '';
79 shouldBeEqualToString('flexbox.style.justifyContent', ''); 79 shouldBeEqualToString('flexbox.style.justifyContent', '');
80 shouldBeEqualToString('window.getComputedStyle(flexbox, null).justifyContent', ' normal'); 80 shouldBeEqualToString('window.getComputedStyle(flexbox, null).justifyContent', ' normal');
81 81
82 shouldBeEqualToString('flexbox.style.alignSelf', ''); 82 shouldBeEqualToString('flexbox.style.alignSelf', '');
83 // The initial value is 'auto', which will be resolved depending on parent's sty le (except for the 'document' element). 83 // The initial value is 'auto'.
84 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'norma l'); 84 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'auto' );
85 shouldBeEqualToString('window.getComputedStyle(document.documentElement, null).a lignSelf', 'normal'); 85 shouldBeEqualToString('window.getComputedStyle(document.documentElement, null).a lignSelf', 'auto');
86 86
87 flexbox.style.alignSelf = 'foo'; 87 flexbox.style.alignSelf = 'foo';
88 shouldBeEqualToString('flexbox.style.alignSelf', ''); 88 shouldBeEqualToString('flexbox.style.alignSelf', '');
89 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'norma l'); 89 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'auto' );
90 90
91 flexbox.style.alignSelf = 'auto'; 91 flexbox.style.alignSelf = 'auto';
92 shouldBeEqualToString('flexbox.style.alignSelf', 'auto'); 92 shouldBeEqualToString('flexbox.style.alignSelf', 'auto');
93 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'norma l'); 93 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'auto' );
94 94
95 flexbox.style.alignSelf = 'flex-start'; 95 flexbox.style.alignSelf = 'flex-start';
96 shouldBeEqualToString('flexbox.style.alignSelf', 'flex-start'); 96 shouldBeEqualToString('flexbox.style.alignSelf', 'flex-start');
97 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'flex- start'); 97 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'flex- start');
98 98
99 flexbox.style.alignSelf = 'flex-end'; 99 flexbox.style.alignSelf = 'flex-end';
100 shouldBeEqualToString('flexbox.style.alignSelf', 'flex-end'); 100 shouldBeEqualToString('flexbox.style.alignSelf', 'flex-end');
101 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'flex- end'); 101 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'flex- end');
102 102
103 flexbox.style.alignSelf = 'center'; 103 flexbox.style.alignSelf = 'center';
104 shouldBeEqualToString('flexbox.style.alignSelf', 'center'); 104 shouldBeEqualToString('flexbox.style.alignSelf', 'center');
105 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'cente r'); 105 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'cente r');
106 106
107 flexbox.style.alignSelf = 'stretch'; 107 flexbox.style.alignSelf = 'stretch';
108 shouldBeEqualToString('flexbox.style.alignSelf', 'stretch'); 108 shouldBeEqualToString('flexbox.style.alignSelf', 'stretch');
109 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'stret ch'); 109 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'stret ch');
110 110
111 flexbox.style.alignSelf = 'baseline'; 111 flexbox.style.alignSelf = 'baseline';
112 shouldBeEqualToString('flexbox.style.alignSelf', 'baseline'); 112 shouldBeEqualToString('flexbox.style.alignSelf', 'baseline');
113 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'basel ine'); 113 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'basel ine');
114 114
115 flexbox.style.alignSelf = ''; 115 flexbox.style.alignSelf = '';
116 shouldBeEqualToString('flexbox.style.alignSelf', ''); 116 shouldBeEqualToString('flexbox.style.alignSelf', '');
117 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'norma l'); 117 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignSelf', 'auto' );
118 118
119 shouldBeEqualToString('flexbox.style.alignItems', ''); 119 shouldBeEqualToString('flexbox.style.alignItems', '');
120 shouldBeEqualToString('flexitem.style.alignSelf', ''); 120 shouldBeEqualToString('flexitem.style.alignSelf', '');
121 // The initial value is 'auto', which will be resolved to 'normal' in case of fl exbox containers. 121 // The initial value is 'auto'.
122 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al'); 122 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al');
123 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'norm al'); 123 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'auto ');
124 124
125 flexbox.style.alignItems = 'foo'; 125 flexbox.style.alignItems = 'foo';
126 shouldBeEqualToString('flexbox.style.alignItems', ''); 126 shouldBeEqualToString('flexbox.style.alignItems', '');
127 shouldBeEqualToString('flexitem.style.alignSelf', ''); 127 shouldBeEqualToString('flexitem.style.alignSelf', '');
128 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al'); 128 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al');
129 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'norm al'); 129 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'auto ');
130 130
131 // The 'auto' value is not valid for the align-items property. 131 // The 'auto' value is not valid for the align-items property.
132 flexbox.style.alignItems = 'auto'; 132 flexbox.style.alignItems = 'auto';
133 shouldBeEqualToString('flexbox.style.alignItems', ''); 133 shouldBeEqualToString('flexbox.style.alignItems', '');
134 shouldBeEqualToString('flexitem.style.alignSelf', ''); 134 shouldBeEqualToString('flexitem.style.alignSelf', '');
135 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al'); 135 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al');
136 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'norm al'); 136 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'auto ');
137 137
138 flexbox.style.alignItems = 'flex-start'; 138 flexbox.style.alignItems = 'flex-start';
139 shouldBeEqualToString('flexbox.style.alignItems', 'flex-start'); 139 shouldBeEqualToString('flexbox.style.alignItems', 'flex-start');
140 shouldBeEqualToString('flexitem.style.alignSelf', ''); 140 shouldBeEqualToString('flexitem.style.alignSelf', '');
141 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'flex -start'); 141 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'flex -start');
142 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'flex -start'); 142 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'flex -start');
143 143
144 flexbox.style.alignItems = 'flex-end'; 144 flexbox.style.alignItems = 'flex-end';
145 shouldBeEqualToString('flexbox.style.alignItems', 'flex-end'); 145 shouldBeEqualToString('flexbox.style.alignItems', 'flex-end');
146 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'flex -end'); 146 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'flex -end');
(...skipping 10 matching lines...) Expand all
157 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'stre tch'); 157 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'stre tch');
158 158
159 flexbox.style.alignItems = 'baseline'; 159 flexbox.style.alignItems = 'baseline';
160 shouldBeEqualToString('flexbox.style.alignItems', 'baseline'); 160 shouldBeEqualToString('flexbox.style.alignItems', 'baseline');
161 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'base line'); 161 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'base line');
162 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'base line'); 162 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'base line');
163 163
164 flexbox.style.alignItems = ''; 164 flexbox.style.alignItems = '';
165 shouldBeEqualToString('flexbox.style.alignItems', ''); 165 shouldBeEqualToString('flexbox.style.alignItems', '');
166 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al'); 166 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al');
167 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'norm al'); 167 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'auto ');
168 168
169 flexbox.style.display = 'none'; 169 flexbox.style.display = 'none';
170 shouldBeEqualToString('flexbox.style.alignItems', ''); 170 shouldBeEqualToString('flexbox.style.alignItems', '');
171 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al'); 171 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignItems', 'norm al');
172 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'norm al'); 172 shouldBeEqualToString('window.getComputedStyle(flexitem, null).alignSelf', 'auto ');
173 flexbox.style.display = 'flex'; 173 flexbox.style.display = 'flex';
174 174
175 175
176 // FIXME: This should probably return stretch. See https://bugs.webkit.org/show_ bug.cgi?id=14563. 176 // FIXME: This should probably return stretch. See https://bugs.webkit.org/show_ bug.cgi?id=14563.
177 var detachedFlexbox = document.createElement('div'); 177 var detachedFlexbox = document.createElement('div');
178 var detachedFlexItem = document.createElement('div'); 178 var detachedFlexItem = document.createElement('div');
179 detachedFlexbox.appendChild(detachedFlexItem); 179 detachedFlexbox.appendChild(detachedFlexItem);
180 shouldBeEqualToString('window.getComputedStyle(detachedFlexbox, null).alignSelf' , ''); 180 shouldBeEqualToString('window.getComputedStyle(detachedFlexbox, null).alignSelf' , '');
181 shouldBeEqualToString('window.getComputedStyle(detachedFlexItem, null).alignSelf ', ''); 181 shouldBeEqualToString('window.getComputedStyle(detachedFlexItem, null).alignSelf ', '');
182 182
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 flexbox.style.alignContent = ''; 308 flexbox.style.alignContent = '';
309 shouldBeEqualToString('flexbox.style.alignContent', ''); 309 shouldBeEqualToString('flexbox.style.alignContent', '');
310 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignContent', 'no rmal'); 310 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignContent', 'no rmal');
311 311
312 flexbox.style.alignContent = 'foo'; 312 flexbox.style.alignContent = 'foo';
313 shouldBeEqualToString('flexbox.style.alignContent', ''); 313 shouldBeEqualToString('flexbox.style.alignContent', '');
314 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignContent', 'no rmal'); 314 shouldBeEqualToString('window.getComputedStyle(flexbox, null).alignContent', 'no rmal');
315 </script> 315 </script>
316 </body> 316 </body>
317 </html> 317 </html>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698