third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html - Issue 2455093002: [css-align] Don't resolve 'auto' values for computed style.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html

Issue 2455093002: [css-align] Don't resolve 'auto' values for computed style. (Closed)

Patch Set: Removed some outdated comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html ('k') | third_party/WebKit/LayoutTests/fast/alignment/ensure-flexbox-compatibility-with-initial-values-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2	2

3 <style>	3 <style>

4 .container {	4 .container {

5 background: grey;	5 background: grey;

6 width: 200px;	6 width: 200px;

7 height: 100px;	7 height: 100px;

8 }	8 }

9 .grid { display: grid; }	9 .grid { display: grid; }

10 .flex { display: flex; }	10 .flex { display: flex; }

11 .itemsCenter {	11 .selfCenter {

12 align-items: center;	12 align-self: center;

13 justify-items: center;	13 justify-self: center;

14 }	14 }

15 </style>	15 </style>

16	16

17 <p>Grid item created as anonymous box to contain the text element. The text elem ent should be centered in both axis due to the Default Alignment 'center' value on its container.</p>	17 <p>Grid item created as anonymous box to contain the text element. The text elem ent should be centered in both axis due to the Default Alignment 'center' value on its container.</p>

18 <div class="container grid itemsCenter">	18 <div class="container grid">

19 <div>foobar</div>	19 <div class="selfCenter">foobar</div>

20 </div>	20 </div>

21	21

22 <p>Flex item created as anonymous box to contain the text element. The text elem ent should be centered in both axis due to the Default Alignment 'center' value on its container.</p>	22 <p>Flex item created as anonymous box to contain the text element. The text elem ent should be centered in cross axis due to the Default Alignment 'center' value on its container.</p>

23 <div class="container flex itemsCenter">	23 <div class="container flex">

24 <div>foobar</div>	24 <div class="selfCenter">foobar</div>
	cbiesinger 2017/05/24 16:54:15 I think it would be easier to understand if you on I think it would be easier to understand if you only apply align-self to flex, not both. jfernandez 2017/05/24 22:46:58 The issue is present in both layout models. Do you Show quoted text On 2017/05/24 16:54:15, cbiesinger wrote: > I think it would be easier to understand if you only apply align-self to flex, > not both. The issue is present in both layout models. Do you mean we should define two different tests for each one ?
25 </div>	25 </div>

OLD	NEW