Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2455073003: Compute NativeBehavior for foreign functions. (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -153 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 16 chunks +239 lines, -137 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 3 chunks +149 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Johnni Winther
4 years, 1 month ago (2016-10-28 12:50:54 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2455073003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2455073003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode333 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:333: node.arguments.named.isNotEmpty) { move the logic to get the ...
4 years, 1 month ago (2016-10-31 21:17:09 UTC) #3
Johnni Winther
https://codereview.chromium.org/2455073003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2455073003/diff/20001/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode333 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:333: node.arguments.named.isNotEmpty) { On 2016/10/31 21:17:09, Harry Terkelsen wrote: > ...
4 years, 1 month ago (2016-11-01 11:53:27 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as 7db10e4d435dd8026b03adfa912814491977f1af (presubmit successful).
4 years, 1 month ago (2016-11-01 11:59:23 UTC) #6
Johnni Winther
4 years, 1 month ago (2016-11-02 15:09:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
00521e1e130d8b6a4c690b2fdb35ab7b67c3556c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698