Merge 2883: Do not SendPasswordForms when LocalFrame is being detached

Merge 2883: Do not SendPasswordForms when LocalFrame is being detached

Manually merged after resolving conflict with crbug.com/646610

This patch stops PasswordAutofillAgent::SendPasswordForms() to
enumerates forms in the document when LocalFrame is being detached.

This patch does not address the root cause of issue 561873 nor
issue 595078, but it is expected to reduce the crashes by large, and
it is reasonable not to fill passwords when Page is being destroyed.

TBR=dcheng@chromium.org, vabr@chromium.org
BUG=561873, 595078, 654654
Review-Url: https://codereview.chromium.org/2398733004
Cr-Commit-Position: refs/heads/master@{#424692}
(cherry picked from commit a398abc5085c5dc2d8db3076543072d1f196d668)

Committed: https://chromium.googlesource.com/chromium/src/+/79173dcd6d83bfacb4c5f389067822cfb69223f4

[kojii, 2016-10-28 06:21:37]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 06:21:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 06:21:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:21:49]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[kojii, 2016-10-28 06:42:22]

Description was changed from

==========
Merge 2883: Do not SendPasswordForms when LocalFrame is being detached

Manually merged after resolving conflict with crbug.com/646610

This patch stops PasswordAutofillAgent::SendPasswordForms() to
enumerates forms in the document when LocalFrame is being detached.

This patch does not address the root cause of issue 561873 nor
issue 595078, but it is expected to reduce the crashes by large, and
it is reasonable not to fill passwords when Page is being destroyed.

TBR=dcheng@chromium.org, vabr@chromium.org
BUG=561873, 595078, 654654

Review-Url: https://codereview.chromium.org/2398733004
Cr-Commit-Position: refs/heads/master@{#424692}
(cherry picked from commit a398abc5085c5dc2d8db3076543072d1f196d668)
==========

to

==========
Merge 2883: Do not SendPasswordForms when LocalFrame is being detached

Manually merged after resolving conflict with crbug.com/646610

This patch stops PasswordAutofillAgent::SendPasswordForms() to
enumerates forms in the document when LocalFrame is being detached.

This patch does not address the root cause of issue 561873 nor
issue 595078, but it is expected to reduce the crashes by large, and
it is reasonable not to fill passwords when Page is being destroyed.

TBR=dcheng@chromium.org, vabr@chromium.org
BUG=561873, 595078, 654654

Review-Url: https://codereview.chromium.org/2398733004
Cr-Commit-Position: refs/heads/master@{#424692}
(cherry picked from commit a398abc5085c5dc2d8db3076543072d1f196d668)

Committed:
https://chromium.googlesource.com/chromium/src/+/79173dcd6d83bfacb4c5f3890678...
==========

[kojii, 2016-10-28 06:42:24]

Committed patchset #1 (id:1) manually as
79173dcd6d83bfacb4c5f389067822cfb69223f4 (presubmit successful).

[dcheng, 2016-10-28 12:45:50]

LGTM