Moving ScheduleNewAnalysis to break the cycle

appengine/findit/crash/findit_for_chromecrash.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
 from crash import detect_regression_range
 from crash.changelist_classifier import ChangelistClassifier
@@ skipping 31 matching lines @@
       logging.warning('FinditForChromeCrash is abstract, '
           'but someone constructed an instance and called _ClientID')
     else:
       logging.warning(
           'FinditForChromeCrash subclass %s forgot to implement _ClientID',
           cls.__name__)
     raise NotImplementedError()
 
   # TODO(http://crbug.com/659354): remove the dependency on CrashConfig
   # entirely, by passing the relevant data as arguments to this constructor.
-  def __init__(self, repository, pipeline_cls):
-    super(FinditForChromeCrash, self).__init__(repository, pipeline_cls)
+  def __init__(self, repository):
+    super(FinditForChromeCrash, self).__init__(repository)
     component_classifier_config = CrashConfig.Get().component_classifier
 
     self._stacktrace_parser = ChromeCrashParser()
 
     # For how these two "top n" differ, see http://crbug.com/644476#c4
     self._predator = Predator(
         cl_classifier = ChangelistClassifier(
             repository = repository,
             top_n_frames = self.config.get('top_n', _DEFAULT_TOP_N)),
         component_classifier = ComponentClassifier(
@@ skipping 86 matching lines @@
   def _ClientID(cls):
     return CrashClient.FRACAS
 
   def CreateAnalysis(self, crash_identifiers):
     # TODO: inline FracasCrashAnalysis.Create stuff here.
     return FracasCrashAnalysis.Create(crash_identifiers)
 
   def GetAnalysis(self, crash_identifiers):
     # TODO: inline FracasCrashAnalysis.Get stuff here.
     return FracasCrashAnalysis.Get(crash_identifiers)