Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: appengine/findit/crash/findit_for_chromecrash.py

Issue 2455053004: Moving ScheduleNewAnalysis to break the cycle (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 6
7 from google.appengine.ext import ndb 7 from google.appengine.ext import ndb
8 8
9 from crash import detect_regression_range 9 from crash import detect_regression_range
10 from crash.azalea import Azalea 10 from crash.azalea import Azalea
(...skipping 30 matching lines...) Expand all
41 logging.warning('FinditForChromeCrash is abstract, ' 41 logging.warning('FinditForChromeCrash is abstract, '
42 'but someone constructed an instance and called _ClientID') 42 'but someone constructed an instance and called _ClientID')
43 else: 43 else:
44 logging.warning( 44 logging.warning(
45 'FinditForChromeCrash subclass %s forgot to implement _ClientID', 45 'FinditForChromeCrash subclass %s forgot to implement _ClientID',
46 cls.__name__) 46 cls.__name__)
47 raise NotImplementedError() 47 raise NotImplementedError()
48 48
49 # TODO(http://crbug.com/659354): remove the dependency on CrashConfig 49 # TODO(http://crbug.com/659354): remove the dependency on CrashConfig
50 # entirely, by passing the relevant data as arguments to this constructor. 50 # entirely, by passing the relevant data as arguments to this constructor.
51 def __init__(self, repository, pipeline_cls): 51 def __init__(self, repository):
52 super(FinditForChromeCrash, self).__init__(repository, pipeline_cls) 52 super(FinditForChromeCrash, self).__init__(repository)
53 component_classifier_config = CrashConfig.Get().component_classifier 53 component_classifier_config = CrashConfig.Get().component_classifier
54 54
55 self._stacktrace_parser = ChromeCrashParser() 55 self._stacktrace_parser = ChromeCrashParser()
56 56
57 # For how these two "top n" differ, see http://crbug.com/644476#c4 57 # For how these two "top n" differ, see http://crbug.com/644476#c4
58 self._azalea = Azalea( 58 self._azalea = Azalea(
59 cl_classifier = ChangelistClassifier( 59 cl_classifier = ChangelistClassifier(
60 repository = repository, 60 repository = repository,
61 top_n_frames = self.config.get('top_n', _DEFAULT_TOP_N)), 61 top_n_frames = self.config.get('top_n', _DEFAULT_TOP_N)),
62 component_classifier = ComponentClassifier( 62 component_classifier = ComponentClassifier(
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 def _ClientID(cls): 149 def _ClientID(cls):
150 return CrashClient.FRACAS 150 return CrashClient.FRACAS
151 151
152 def CreateAnalysis(self, crash_identifiers): 152 def CreateAnalysis(self, crash_identifiers):
153 # TODO: inline FracasCrashAnalysis.Create stuff here. 153 # TODO: inline FracasCrashAnalysis.Create stuff here.
154 return FracasCrashAnalysis.Create(crash_identifiers) 154 return FracasCrashAnalysis.Create(crash_identifiers)
155 155
156 def GetAnalysis(self, crash_identifiers): 156 def GetAnalysis(self, crash_identifiers):
157 # TODO: inline FracasCrashAnalysis.Get stuff here. 157 # TODO: inline FracasCrashAnalysis.Get stuff here.
158 return FracasCrashAnalysis.Get(crash_identifiers) 158 return FracasCrashAnalysis.Get(crash_identifiers)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698