Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 245503003: git-sync-deps verifies that directory is a top-level git directory. (Closed)

Created:
6 years, 8 months ago by hal.canary
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

git-sync-deps verifies that directory is a top-level git directory. NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14285

Patch Set 1 #

Total comments: 2

Patch Set 2 : AnotherPatchSet #

Patch Set 3 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M tools/git-sync-deps View 1 2 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
bad things happened to me as a result of the bug that this fixes.
6 years, 8 months ago (2014-04-21 18:42:52 UTC) #1
mtklein
https://codereview.chromium.org/245503003/diff/1/tools/git-sync-deps File tools/git-sync-deps (right): https://codereview.chromium.org/245503003/diff/1/tools/git-sync-deps#newcode110 tools/git-sync-deps:110: sys.stdout.write('%s\n IS NOT TOP-LEVEL GIT DIRECTORY.\n' % directory) and ...
6 years, 8 months ago (2014-04-21 18:44:48 UTC) #2
hal.canary
https://codereview.chromium.org/245503003/diff/1/tools/git-sync-deps File tools/git-sync-deps (right): https://codereview.chromium.org/245503003/diff/1/tools/git-sync-deps#newcode110 tools/git-sync-deps:110: sys.stdout.write('%s\n IS NOT TOP-LEVEL GIT DIRECTORY.\n' % directory) On ...
6 years, 8 months ago (2014-04-21 18:53:33 UTC) #3
mtklein
lgtm
6 years, 8 months ago (2014-04-21 18:55:27 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 8 months ago (2014-04-21 19:02:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/245503003/40001
6 years, 8 months ago (2014-04-21 19:02:39 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 19:03:07 UTC) #7
Message was sent while issue was closed.
Change committed as 14285

Powered by Google App Engine
This is Rietveld 408576698