Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 24550006: remove Local::New with no isolate parameter (Closed)

Created:
7 years, 2 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

remove Local::New with no isolate parameter R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16972

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -43 lines) Patch
M include/v8.h View 1 2 7 chunks +14 lines, -20 lines 0 comments Download
M src/api.cc View 1 2 2 chunks +7 lines, -12 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal note: this has to wait for chrome and blink patches to land
7 years, 2 months ago (2013-09-26 10:23:42 UTC) #1
Michael Starzinger
LGTM if comments are addressed. https://codereview.chromium.org/24550006/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/24550006/diff/1/src/api.cc#newcode700 src/api.cc:700: return reinterpret_cast<i::Object**>( nit: The ...
7 years, 2 months ago (2013-09-26 10:58:31 UTC) #2
dcarney
7 years, 2 months ago (2013-09-27 07:04:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698