[Smart Lock] Account chooser assign correct avatar to profile.

[Smart Lock] Account chooser assign correct avatar to profile.

Fixes the bug, where avatar doesn't correspond to correct account in the
Account Chooser Dialog on Android.

BUG=660029
Committed: https://crrev.com/1a46b550f643ef7199915d087f9861406763d3e9
Cr-Commit-Position: refs/heads/master@{#428609}

[melandory, 2016-10-28 11:41:15]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 11:41:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-28 11:42:07]

melandory@chromium.org changed reviewers:
+ vasilii@chromium.org

[melandory, 2016-10-28 11:42:07]

PTAL, thanks!

[commit-bot: I haz the power, 2016-10-28 12:09:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 12:09:23]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-10-28 12:58:00]

What about a unit test?

[melandory, 2016-10-28 13:32:37]

On 2016/10/28 12:58:00, vasilii wrote:
> What about a unit test?
Unfortunately, they will be very un-trivial. I can promise to write them after
my OOO.

[vasilii, 2016-10-28 14:24:22]

Alternatively, you can bring me a present from vacation ;-)

LGTM

https://codereview.chromium.org/2454993004/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/account_chooser_dialog_android.cc (right):

https://codereview.chromium.org/2454993004/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/account_chooser_dialog_android.cc:94: const
std::unique_ptr<autofill::PasswordForm>& password_form,
It's better to accept 'const PasswordForm&' here.

[melandory, 2016-10-29 07:33:39]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 07:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-29 07:34:21]

The CQ bit was unchecked by melandory@chromium.org

[melandory, 2016-10-29 07:34:29]

The CQ bit was checked by melandory@chromium.org

[melandory, 2016-10-29 07:34:30]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2454993004/#ps20001
(title: ".")

[melandory, 2016-10-29 07:34:36]

https://codereview.chromium.org/2454993004/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/account_chooser_dialog_android.cc (right):

https://codereview.chromium.org/2454993004/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/account_chooser_dialog_android.cc:94: const
std::unique_ptr<autofill::PasswordForm>& password_form,
On 2016/10/28 14:24:21, vasilii wrote:
> It's better to accept 'const PasswordForm&' here.

PasswordForm doesn't have const icon_url getter.

[commit-bot: I haz the power, 2016-10-29 07:34:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 08:07:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-29 08:09:59]

Description was changed from

==========
[Smart Lock] Account chooser assign correct avatar to profile.

Fixes the bug, where avatar doesn't correspond to correct account in the
Account Chooser Dialog on Android.

BUG=660029
==========

to

==========
[Smart Lock] Account chooser assign correct avatar to profile.

Fixes the bug, where avatar doesn't correspond to correct account in the
Account Chooser Dialog on Android.

BUG=660029

Committed: https://crrev.com/1a46b550f643ef7199915d087f9861406763d3e9
Cr-Commit-Position: refs/heads/master@{#428609}
==========

[commit-bot: I haz the power, 2016-10-29 08:10:00]

Patchset 2 (id:??) landed as
https://crrev.com/1a46b550f643ef7199915d087f9861406763d3e9
Cr-Commit-Position: refs/heads/master@{#428609}

[vasilii, 2016-10-31 08:57:41]

https://codereview.chromium.org/2454993004/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/account_chooser_dialog_android.cc (right):

https://codereview.chromium.org/2454993004/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/account_chooser_dialog_android.cc:94: const
std::unique_ptr<autofill::PasswordForm>& password_form,
On 2016/10/29 07:34:36, melandory wrote:
> On 2016/10/28 14:24:21, vasilii wrote:
> > It's better to accept 'const PasswordForm&' here.
> 
> PasswordForm doesn't have const icon_url getter.

What does this mean??