Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2454993003: Remove custom expect.dart from Kernel tests (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -59 lines) Patch
M tests/kernel/unsorted/as_is_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/block_scope_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/kernel/unsorted/breakable_statement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/closures_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/closures_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/conditional_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/constant_evaluator_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/constant_expressions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/kernel/unsorted/expect.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/kernel/unsorted/factory_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/field_dispatcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/finally_contexts_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/for_in_loop_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/getters_and_setters_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/global_field_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/instance_getters_and_setters_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/invocation_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/invocation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/klass_field_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/let_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/load_store_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/local_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/loop_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/mapliteral_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/mixin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/nsm_dispatcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/nullable_operator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/rethrow_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/return_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/simple_literal_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/string_concatenation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/super_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/super_mixin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/super_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/superclass_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/switch_case_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/symbol_literal_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/this_capture_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/this_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/throw_try_catch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/try_finally_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/type_args_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/kernel/unsorted/types_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-10-27 13:11:48 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 40611dd6111d5cecbd01bec2cf3bb9e2e5fb1e17 (presubmit successful).
4 years, 1 month ago (2016-10-27 13:14:07 UTC) #3
kustermann
4 years, 1 month ago (2016-10-27 13:24:01 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698