Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2454943004: Add a //chrome/common dep to //chrome/browser/devtools (Closed)

Created:
4 years, 1 month ago by tsniatowski
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a //chrome/common dep to //chrome/browser/devtools Devtools include chrome/common headers which include the generated features header, so without the dep the build is flaky. BUG=655123 Committed: https://crrev.com/e414cb39fc1746256be57f3d364b6e90a0211a59 Cr-Commit-Position: refs/heads/master@{#428413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tsniatowski
On 2016/10/28 07:23:35, tsniatowski wrote: > mailto:tsniatowski@opera.com changed reviewers: > + mailto:dgozman@chromium.org PTAL
4 years, 1 month ago (2016-10-28 07:23:42 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-10-28 17:06:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454943004/1
4 years, 1 month ago (2016-10-28 17:10:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:44:10 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:53:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e414cb39fc1746256be57f3d364b6e90a0211a59
Cr-Commit-Position: refs/heads/master@{#428413}

Powered by Google App Engine
This is Rietveld 408576698