Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2454943003: Remove deprecated option --no-new-test-results from run-webkit-tests. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, ojan
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated option --no-new-test-results from run-webkit-tests. Committed: https://crrev.com/c58fcdb5a500f764ed3c6a38b074887897b92e61 Cr-Commit-Position: refs/heads/master@{#428233}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
qyearsley
4 years, 1 month ago (2016-10-27 21:46:17 UTC) #2
Dirk Pranke
lgtm. https://codereview.chromium.org/2454943003/diff/1/third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh File third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh (right): https://codereview.chromium.org/2454943003/diff/1/third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh#newcode78 third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh:78: complete -o default -W "--add-platform-exceptions --complex-text --configuration --guard-malloc ...
4 years, 1 month ago (2016-10-27 22:13:11 UTC) #3
qyearsley
On 2016/10/27 at 22:13:11, dpranke wrote: > lgtm. > > https://codereview.chromium.org/2454943003/diff/1/third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh > File third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh (right): ...
4 years, 1 month ago (2016-10-28 00:11:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454943003/1
4 years, 1 month ago (2016-10-28 00:12:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 01:37:32 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 01:40:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c58fcdb5a500f764ed3c6a38b074887897b92e61
Cr-Commit-Position: refs/heads/master@{#428233}

Powered by Google App Engine
This is Rietveld 408576698