third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html - Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html

Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV (Closed)

Patch Set: Fix VisualViewportTest Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt » ('j') | third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html

diff --git a/third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html b/third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html

index f16af2474d48ecb29dbeedb9c41c6a07b589a5a9..04ca106feae630dea84f8812d1474e7c94191245 100644

--- a/third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html

+++ b/third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html

@@ -13,11 +13,11 @@

window.internals.settings.setPreferCompositingToLCDTextEnabled(true);

document.execCommand("FindString", false, "target");

- document.getElementById("result").innerText = internals.visualViewportScrollY() === 860 ? "PASS" : "FAIL (scrollTop:" + document.scrollingElement.scrollTop + ")";

+ document.getElementById("result").innerText = internals.visualViewportScrollY() === 863 ? "PASS" : "FAIL (scrollTop:" + document.scrollingElement.scrollTop + ")";

ymalik 2016/11/03 18:49:12 This is expected because the calculation in scroll

bokan 2016/11/03 19:59:59 Acknowledged.

window.internals.settings.setPreferCompositingToLCDTextEnabled(false);

document.execCommand("FindString", false, "target");

- document.getElementById("result").innerText += internals.visualViewportScrollY() === 860 ? " PASS" : " FAIL (scrollTop:" + document.scrollingElement.scrollTop + ")";

+ document.getElementById("result").innerText += internals.visualViewportScrollY() === 863 ? " PASS" : " FAIL (scrollTop:" + document.scrollingElement.scrollTop + ")";

};

</script>

</body>